-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixed reader loading test for hf-hub starting 0.14.0 #4607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some context here 😅
@masci I had reported an issue with HF hub for this problem: huggingface/huggingface_hub#1385 They closed it over a week ago but I never got a chance to fix it. Seems like it's still not fixed with the latest version. |
Converted to draft until HF releases a new version for hf_hub. Everything else is passing now. |
hf_hub new version (i.e., 0.14.0) should have the fix. just testing it now. |
Related Issues
I am just fixing this issue since hf_hub seems to have fixed it now.
Proposed Changes:
Use pytest defined tmp_folder
How did you test it?
unit test
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.