Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed reader loading test for hf-hub starting 0.14.0 #4607

Merged
merged 9 commits into from
May 2, 2023

Conversation

mayankjobanputra
Copy link
Contributor

@mayankjobanputra mayankjobanputra commented Apr 5, 2023

Related Issues

I am just fixing this issue since hf_hub seems to have fixed it now.

Proposed Changes:

Use pytest defined tmp_folder

How did you test it?

unit test

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mayankjobanputra mayankjobanputra requested a review from a team as a code owner April 5, 2023 14:16
@mayankjobanputra mayankjobanputra requested review from masci and removed request for a team April 5, 2023 14:16
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some context here 😅

@mayankjobanputra
Copy link
Contributor Author

@masci I had reported an issue with HF hub for this problem: huggingface/huggingface_hub#1385

They closed it over a week ago but I never got a chance to fix it. Seems like it's still not fixed with the latest version.

@mayankjobanputra mayankjobanputra marked this pull request as draft April 13, 2023 21:41
@mayankjobanputra
Copy link
Contributor Author

Converted to draft until HF releases a new version for hf_hub. Everything else is passing now.

@mayankjobanputra mayankjobanputra marked this pull request as ready for review April 25, 2023 12:18
@mayankjobanputra
Copy link
Contributor Author

hf_hub new version (i.e., 0.14.0) should have the fix. just testing it now.

@mayankjobanputra mayankjobanputra requested a review from masci April 25, 2023 16:56
@mayankjobanputra mayankjobanputra changed the title chore: fixed reader loading test for hf-hub starting 0.13.3 chore: fixed reader loading test for hf-hub starting 0.14.0 Apr 28, 2023
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 34.966%. Remained the same when pulling 766007f on hf_hub_test_fix into 5a17a40 on main.

@masci masci merged commit 896eb6a into main May 2, 2023
@masci masci deleted the hf_hub_test_fix branch May 2, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants