Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce telemetry events count #4501

Merged
merged 21 commits into from
Mar 27, 2023
Merged

refactor: reduce telemetry events count #4501

merged 21 commits into from
Mar 27, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Mar 27, 2023

Proposed Changes:

  • remove Haystack imported telemetry event
  • make pipelines send one event only for the first run call after the pipeline config has changed meaningfully
  • consolidate LLM events to reduce their impact

How did you test it?

  • CI

Notes for the reviewer

n/a

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@vblagoje
Copy link
Member

@ZanSara Just saw this PR and remembered that we might still be sending events for each PromptTemplate loaded. We should prevent components from sending events automatically on load - if so desired.

@ZanSara
Copy link
Contributor Author

ZanSara commented Mar 27, 2023

@vblagoje that part should be gone in telemetry v2. We're now sending events only on very limited situations. This telemetry should not be to assess absolute usage numbers, just relative ones: which docstore is more popular, which nodes are never used, etc. It doesn't try to understand how many people use the various components, just whether they're used at all.

@ZanSara ZanSara added this to the 1.15.0 milestone Mar 27, 2023
@ZanSara ZanSara marked this pull request as ready for review March 27, 2023 15:43
@ZanSara ZanSara requested a review from a team as a code owner March 27, 2023 15:43
@ZanSara ZanSara requested review from silvanocerza and removed request for a team March 27, 2023 15:43
@ZanSara ZanSara merged commit b52bbea into main Mar 27, 2023
@ZanSara ZanSara deleted the telemetry-less-events branch March 27, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants