test: Fix audio tests failing #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:build/distribution
topic:dependencies
and removed
topic:CI
topic:tests
labels
silvanocerza
changed the title
ZanSara
approved these changes
Mar 15, 2023
|
Same has been done in espnet/espnet#5009, we should be able to remove the pinned |
silvanocerza
force-pushed
the
fix-audio-tests-failure
branch
from
70103a7 to
1a4b81f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
espnetdepends on a library calledtypeguardthat recently released a breaking3.0.0version, this PR fixes the version to2.13.3to fix import errors.How did you test it?
Run tests locally.
Notes for the reviewer
This is a quick fix that will be removed as soon as we merge #4391, we'll still need to port the fix in the
haystack-extrasrepo.