Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove deprecated OpenDistroElasticsearchDocumentStore #4361

Merged
merged 2 commits into from
Mar 14, 2023
Merged

chore!: remove deprecated OpenDistroElasticsearchDocumentStore #4361

merged 2 commits into from
Mar 14, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Mar 9, 2023 •
edited
Loading

Related Issues

Proposed Changes:

Remove long-time deprecated, useless (it's just an alias) OpenDistroElasticsearchDocumentStore

How did you test it?

Notes for the reviewer

  • documentation page was updated accordingly, Python API docs will be automatically updated after merging this PR.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@masci masci requested a review from a team as a code owner March 9, 2023 07:23
@masci masci requested review from mayankjobanputra and removed request for a team March 9, 2023 07:23
ZanSara
ZanSara approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZanSara ZanSara requested review from agnieszka-m and removed request for mayankjobanputra March 9, 2023 13:44
@masci masci merged commit 5aa19ff into main Mar 14, 2023
@masci masci deleted the massi/remove-deprecated branch March 14, 2023 08:12
NikolaMr pushed a commit to NikolaMr/haystack that referenced this pull request Mar 14, 2023
@masci @NikolaMr
remove deprecated OpenDistroElasticsearchDocumentStore (deepset-ai#4361)
1ee8b0e
@anakin87 anakin87 mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

@agnieszka-m agnieszka-m Awaiting requested review from agnieszka-m

Assignees
No one assigned
Labels
breaking change topic:document_store topic:opensearch topic:retriever topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @ZanSara