Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bug in prompt template check of OpenAIAnswerGenerator #4220

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: Fix bug in prompt template check of OpenAIAnswerGenerator #4220

merged 1 commit into from
Feb 21, 2023

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 21, 2023 •
edited
Loading

Related Issues

Proposed Changes:

Fixed bug for using custom templates in OpenAIAnswerGenerator due to a bad check.

How did you test it?

Added new test using custom template.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner February 21, 2023 10:44
@sjrl sjrl requested review from ZanSara and removed request for a team February 21, 2023 10:44
@sjrl sjrl added this to the 1.14.0 milestone Feb 21, 2023
@vblagoje vblagoje self-requested a review February 21, 2023 11:15
@sjrl sjrl merged commit 2bedb80 into main Feb 21, 2023
@sjrl sjrl deleted the fix/openai_answergenerator branch February 21, 2023 12:35
vblagoje pushed a commit that referenced this pull request Feb 22, 2023
@sjrl @vblagoje
Fix for custom template in OpenAIAnswerGenerator (#4220)
e94bd24
@ZanSara ZanSara removed their request for review February 28, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
topic:tests
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

OpenAIAnswerGenerator not working with custom prompt_template
2 participants
@sjrl @vblagoje