feat: include testing facilities into haystack package #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:document_store
topic:elasticsearch
topic:faiss
topic:milvus
topic:opensearch
topic:pinecone
topic:sql
topic:tests
topic:weaviate
type:documentation
masci
force-pushed
the
massi/extract-testing
branch
from
0fd3ea3 to
8d2967b
Compare
masci
force-pushed
the
massi/extract-testing
branch
from
8d2967b to
6e65fad
Compare
masci
force-pushed
the
massi/extract-testing
branch
from
6e65fad to
15f94b3
Compare
masci
commented
Feb 17, 2023
| import sys | ||
| import os | ||
|
|
||
| import yaml |
There was a problem hiding this comment.
I took the chance to remove some unused imports in this module, not related to the PR main goal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Move the base class for document store testing into Haystack's core, so that it will be shipped with the farm-haystack package and used from external packages.
How did you test it?
CI
Notes for the reviewer
/cc @TuanaCelik
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.