Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pin soundfile to fix CI #4163

Closed
wants to merge 1 commit into from
Closed

fix: Pin soundfile to fix CI #4163

wants to merge 1 commit into from

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 15, 2023 •
edited
Loading

Related Issues

  • fixes failing audio test in CI

Proposed Changes:

How did you test it?

Existing tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner February 15, 2023 09:32
@sjrl sjrl requested review from vblagoje and removed request for a team February 15, 2023 09:32
@sjrl sjrl changed the title Pin soundfile to fix CI fix: Pin soundfile to fix CI Feb 15, 2023
@sjrl sjrl added type:bug Something isn't working topic:CI labels Feb 15, 2023
@sjrl sjrl mentioned this pull request Feb 16, 2023
Merged
6 tasks
@masci
Copy link
Contributor

masci commented Feb 16, 2023

Hey @sjrl thanks for the fix but we're going with #4128, I'm closing this

@masci masci closed this Feb 16, 2023
@sjrl sjrl deleted the ci-audio branch July 3, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:build/distribution topic:CI topic:dependencies type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrl @masci