fix: removing code block in MarkdownConverter
#3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuanaCelik
requested review from
julian-risch and
bogdankostic
and removed request for
a team
|
Sorry @bogdankostic , I made the change by branching off fro the branch that is still in an open PR: #3953 which is why it looks like there are more changes that needed.. I think it should appear normally once that branch is merged? Or should I create a new PR and close this? |
|
Should be okay, let's wait for the CI to become green in #3953 and then merge. |
|
@bogdankostic pausing this until tomorrow to add a test first |
|
@bogdankostic there's a test ready. As the default is set to 'True' it's a bit odd because it means I'm testing the scenarion where the code block is not removed |
bogdankostic
approved these changes
Jan 27, 2023
ZanSara
pushed a commit
that referenced
this pull request
Feb 2, 2023
* first attempt to add frontmatter of markdown to the metadata * remove bug fix * running black and pre-commit * moving the import line * adding a test * adding pydoc * fix to removing code blocks in markdown converter * adding a test * fixing a test * improving tests * adding language to code block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
change the line
html = markdown(markdown_text)tohtml = markdown(markdown_text, extensions=["fenced_code"])as suggested in the issue discussionChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.