Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow users to set a timeout for remote APIs #3949

Merged
merged 5 commits into from
Jan 27, 2023
Merged

feat: Allow users to set a timeout for remote APIs #3949

merged 5 commits into from
Jan 27, 2023

Conversation

danielbichuetti
Copy link
Contributor

Related Issues

Proposed Changes:

Add environment variable to control remote APIs (OpenAI and CoHere) timeouts.
Same pattern implemented at PromptNode

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@danielbichuetti danielbichuetti requested a review from a team as a code owner January 26, 2023 04:00
@danielbichuetti danielbichuetti requested review from ZanSara and removed request for a team January 26, 2023 04:00
@sjrl sjrl added the type:feature New feature or request label Jan 26, 2023
ZanSara
ZanSara approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you 😊

@ZanSara ZanSara requested a review from agnieszka-m January 27, 2023 10:30
@ZanSara ZanSara merged commit 8efdac1 into deepset-ai:main Jan 27, 2023
@nickprock
Copy link
Contributor

Hi, is it the same for Haystack 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

@agnieszka-m agnieszka-m Awaiting requested review from agnieszka-m

Assignees
No one assigned
Labels
topic:LLM type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include time_out in the answer_generator run method
5 participants
@danielbichuetti @nickprock @ZanSara @sjrl @bogdankostic