feat: adding secure loading of models by default for haystack #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankjobanputra
requested review from
julian-risch
and removed request for
a team
mayankjobanputra
changed the title
masci
suggested changes
Jan 23, 2023
julian-risch
requested changes
Jan 23, 2023
| @@ -18,6 +18,12 @@ | |||
| env_meta_data: Dict[str, Any] = {} | |||
|
|
|||
|
|
|||
| def set_pytorch_secure_model_loading(flag_val="1"): | |||
| # To load secure only model pytorch requires value of | |||
| # TORCH_FORCE_WEIGHTS_ONLY_LOAD to be ["1", "y", "yes", "true"] | |||
There was a problem hiding this comment.
I think we should check whether this flag is set to any value different from ["1", "y", "yes", "true"] before setting it to 1. Maybe a user explicitly set it to False. In that case we shouldn't silently overwrite it. Instead, let's at least log a warning.
There was a problem hiding this comment.
Changed it. I think your suggestion is taken care of, but please do let me know if you disagree.
masci
approved these changes
Jan 24, 2023
Co-authored-by: Massimiliano Pippi <[email protected]>
julian-risch
approved these changes
Jan 24, 2023
ZanSara
pushed a commit
that referenced
this pull request
Jan 27, 2023
* adding secure loading of models by default * simplified set function * testing import effect correctly * added appropriate log line, adapted the test * change log string formatting Co-authored-by: Massimiliano Pippi <[email protected]> * remove extra closing bracket ) Co-authored-by: Julian Risch <[email protected]> Co-authored-by: Massimiliano Pippi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
setting TORCH_FORCE_WEIGHTS_ONLY_LOAD to 1 by default
How did you test it?
added unit test
Notes for the reviewer
To load secure-only model pytorch requires the value of TORCH_FORCE_WEIGHTS_ONLY_LOAD to be ["1", "y", "yes", "true"]
For more details please refer to pytorch PR pytorch/pytorch#87443.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.