Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate multiple no answers in MultiLabel #324

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Aggregate multiple no answers in MultiLabel #324

merged 2 commits into from
Aug 18, 2020

Conversation

bogdankostic
Copy link
Contributor

This PR aggregates multiple no answers in different documents for the same question. Before, only one no answer was present in MultiLabel.

@bogdankostic bogdankostic requested a review from Timoeller August 18, 2020 15:59
Timoeller
Timoeller approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the change and especially the tests.

We also have to add some special logic for evaluating "no answer" cases in the open domain QA setting. Lets do that once we have data for the case of multiple "no answer" per question

@Timoeller Timoeller merged commit f388ca0 into master Aug 18, 2020
@julian-risch julian-risch deleted the aggregate_no_answers branch November 15, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdankostic @Timoeller