Fix type of query_emb in DPR.retrieve() #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tholor
approved these changes
Jul 18, 2020
There was a problem hiding this comment.
Thanks a lot for spotting and fixing it @antoniolanza1996 !
You are totally right. I missed this typecast yesterday in the refactoring.
|
Your welcome. Indeed, thanks for your outstanding work on this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring of query_by_embedding function in the commit 355be29, DPR has stopped to work.
According to your EmbeddingRetriever retrieve function implementation, I have fixed DPR retrieve function. Hope it helps.