Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL or in-memory document stores for dense retriever (DPR) #316

Closed
venuraja79 opened this issue Aug 17, 2020 · 5 comments
Closed

SQL or in-memory document stores for dense retriever (DPR) #316

venuraja79 opened this issue Aug 17, 2020 · 5 comments
Assignees

Comments

@venuraja79
Copy link
Contributor

Question
Hello team - Thanks a lot for this repository. please suggest if it's feasible to extend sql/ in-memory document stores to work with DPR retriever?

Additional context
The update_embeddings method doesn't seem to be implemented. If it's of any value, please suggest. This can be useful for easier/small size deployments. Thank you!

@tanaysoni
Copy link
Contributor

Hi @venuraja79, you can use the DPR Retriever with a FAISS, InMemory, or Elasticsearch document store.

I would suggest using the FAISS document store for DPR. It uses SQL under-the-hood to store the documents and the document embeddings are indexed in a FAISS Index.

The update_embeddings() method is implemented for FAISS and Elasticsearch document stores.

To get started, you can follow the tutorial 6(colab version).

@venuraja79
Copy link
Contributor Author

Thank you @tanaysoni, this helps! Would you be interested if I make a pull request if I implemented it for in-memory store?

@tanaysoni
Copy link
Contributor

That'd be highly appreciated, @venuraja79! I'd suggest making an early work-in-progress pull request. Let me know if there's anything you need to discuss before getting started.

@venuraja79
Copy link
Contributor Author

Sure, Thank you!

@venuraja79
Copy link
Contributor Author

Thank you @tanaysoni. I'll close this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants