Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in reading cp2k/output of cp2k v9.1 (compatible with old ver) #466

Merged
merged 2 commits into from
May 11, 2023

Conversation

ChiahsinChu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.02 ⚠️

Comparison is base (0ccc570) 82.76% compared to head (b076126) 82.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #466      +/-   ##
==========================================
- Coverage   82.76%   82.74%   -0.02%     
==========================================
  Files          70       70              
  Lines        6313     6318       +5     
==========================================
+ Hits         5225     5228       +3     
- Misses       1088     1090       +2     
Impacted Files Coverage Δ
dpdata/cp2k/output.py 97.28% <60.00%> (-0.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz
Copy link
Member

njzjz commented May 8, 2023

xref: readthedocs/readthedocs.org#10290 for failed docs build

@wanghan-iapcm wanghan-iapcm merged commit 63904ed into deepmodeling:devel May 11, 2023
@robinzyb
Copy link
Collaborator

robinzyb commented May 22, 2023

This seems no unittest output is present for 9.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants