Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused tqdm #746

Merged
merged 1 commit into from
Jun 15, 2021
Merged

remove unused tqdm #746

merged 1 commit into from
Jun 15, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 15, 2021

tqdm is not used at present. It may be imported in #350 for tests, but since it is not really used for production, it is safe to remove this requirement.

tqdm is not used at present. It may be
imported in deepmodeling#350 for tests, but since it
is not really used for production, it is safe
to remove this requirement.
@njzjz njzjz changed the base branch from master to devel June 15, 2021 00:16
@njzjz njzjz changed the title devel remove unused tqdm Jun 15, 2021
@njzjz njzjz requested a review from denghuilu June 15, 2021 00:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #746 (f0ba97e) into devel (9997ad6) will decrease coverage by 8.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #746      +/-   ##
==========================================
- Coverage   82.32%   74.21%   -8.11%     
==========================================
  Files         115       82      -33     
  Lines        9522     6520    -3002     
==========================================
- Hits         7839     4839    -3000     
+ Misses       1683     1681       -2     
Impacted Files Coverage Δ
deepmd/utils/neighbor_stat.py 100.00% <ø> (ø)
deepmd/utils/tabulate.py 88.62% <ø> (-0.07%) ⬇️
source/lib/tests/test_prod_force_grad_r.cc
source/lib/tests/test_tabulate.cc
source/lib/tests/test_ewald.cc
source/api_cc/tests/test_deeppot_a.cc
source/lib/tests/test_map_aparam.cc
source/lib/tests/test_soft_min_switch.cc
...ource/lib/tests/test_soft_min_switch_force_grad.cc
source/api_cc/tests/test_deeppot_r.cc
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9997ad6...f0ba97e. Read the comment docs.

Copy link
Member

@denghuilu denghuilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tqdm is no longer needed. There is no problem within this code modification.

@amcadmus amcadmus merged commit c200e9a into deepmodeling:devel Jun 15, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 1, 2021
tqdm is not used at present. It may be
imported in deepmodeling#350 for tests, but since it
is not really used for production, it is safe
to remove this requirement.
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
…vi_job (deepmodeling#786)

* adapt different trust level for different sys_configs

* fix deepmodeling#746; add iter dependent trust level

* add document for deepmodeling#786

* some fix accroding to review
* fix unexpected 0 bug
* fix document not supporting typing bug
* change value for trust level in unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]lmp MD very slow with offline installer compared with compiled myself
4 participants