Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop C++ 11? #4060

Closed
njzjz opened this issue Aug 18, 2024 · 1 comment · Fixed by #4068
Closed

Drop C++ 11? #4060

njzjz opened this issue Aug 18, 2024 · 1 comment · Fixed by #4068
Labels
enhancement

Comments

@njzjz
Copy link
Member

njzjz commented Aug 18, 2024

We've removed support for any TensorFlow/PyTorch versions using C++ 11, so it seems that we can allow C++ 14 in our codes.
@wanghan-iapcm
Copy link
Collaborator

+1

njzjz added a commit to njzjz/deepmd-kit that referenced this issue Aug 20, 2024
@njzjz
breaking: drop C++ 11
4e73831 
Fix deepmodeling#4060.
@njzjz njzjz mentioned this issue Aug 20, 2024
Merged
@njzjz njzjz linked a pull request Aug 20, 2024 that will close this issue
breaking: drop C++ 11 #4068
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@njzjz @pre-commit-ci
breaking: drop C++ 11 (#4068)
560c7df 
Fix #4060.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated installation documentation to clarify C++ compiler
requirements, specifying that GCC 5 or higher is necessary for C++ 14
and potentially GCC 7 for C++ 17.
  
- **Chores**
- Enhanced CMake configuration to support C++ 14 in specific scenarios,
improving compatibility with older codebases.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz closed this as completed Aug 21, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @pre-commit-ci
breaking: drop C++ 11 (deepmodeling#4068)
623cbb5 
Fix deepmodeling#4060.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated installation documentation to clarify C++ compiler
requirements, specifying that GCC 5 or higher is necessary for C++ 14
and potentially GCC 7 for C++ 17.
  
- **Chores**
- Enhanced CMake configuration to support C++ 14 in specific scenarios,
improving compatibility with older codebases.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

breaking: drop C++ 11 njzjz/deepmd-kit
2 participants
@njzjz @wanghan-iapcm