Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin-Kernel-SIG] [linux 6.6-y] deepin: config: enable NVME_HWMON config #555

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jan 13, 2025

+CONFIG_NVME_HWMON:
Help show nvme temp by hwmon device without smartmontools. loongarch is already enabled, so enabled in x86 and arm64.

-CONFIG_RCU_NOCB_CPU:
select by RCU_LAZY, so removed by savedefconfig.

+CONFIG_NVME_HWMON:
Help show nvme temp by hwmon device without smartmontools.
loongarch is already enabled, so enabled in x86 and arm64.

-CONFIG_RCU_NOCB_CPU:
select by RCU_LAZY, so removed by savedefconfig.

Signed-off-by: Wentao Guan <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
Copy link
Member Author

opsiff commented Jan 13, 2025

/ok-to-test

@opsiff opsiff merged commit 4c4697c into linux-6.6.y Jan 13, 2025
9 of 10 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 删除不必要的配置项

    • deepin_arm64_desktop_defconfigdeepin_loongarch_desktop_defconfigdeepin_x86_desktop_defconfig 文件中,删除了 CONFIG_RCU_NOCB_CPU 配置项。这个配置项在三个配置文件中都被删除了,如果这个配置项在特定架构上不再需要,那么删除是合理的。但是,如果这个配置项在某些情况下是必要的,那么应该保留它,并确保在需要时启用。
  2. 新增配置项

    • deepin_arm64_desktop_defconfigdeepin_loongarch_desktop_defconfigdeepin_x86_desktop_defconfig 文件中,新增了 CONFIG_NVME_HWMON 配置项。这个配置项在三个配置文件中都被添加了,这表明在所有这些架构上都需要启用 NVMe 硬件监控功能。这是一个合理的改动,因为它可能有助于提高系统性能或提供更详细的硬件信息。
  3. 代码质量

    • 代码格式和风格保持一致,没有发现明显的格式问题。但是,建议在删除或添加配置项时,添加相应的注释说明为什么需要这样做,以便其他开发者理解这些改动的目的。
  4. 代码性能

    • 新增的 CONFIG_NVME_HWMON 配置项可能会增加系统的开销,因为它需要收集和监控硬件状态。需要确保这个改动不会对系统性能产生负面影响,并且只有在必要时才启用。
  5. 代码安全

    • 没有涉及到安全性的改动,因此不需要特别关注安全性问题。

总体来说,这些改动看起来是合理的,但是需要确保在删除 CONFIG_RCU_NOCB_CPU 配置项之前,已经充分评估了其对系统的影响,并且新增的 CONFIG_NVME_HWMON 配置项不会引入新的安全风险。

@opsiff opsiff deleted the linux-6.6.y-2025-01-13-config branch January 13, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants