Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin-Kernel-SIG] [linux 6.6-y] deepin: config: adjust PSI and RCU config #548

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jan 6, 2025

config: adjust PSI and RCU config
[1] CONFIG_PSI: It has already enabled in x86 and loongarch config, enable it on arm64 config.
[2] CONFIG_RCU_BOOST:
Config helps to boost the priority of preempted RCU readers that block the current preemptible RCU grace period for too long. Enable CONFIG_RCU_BOOST for x86, arm64, loongarch architectures. Link:https://android.googlesource.com/kernel/common/+/83571e3b13db8d4ce64cc62644b35181125867cf
[3] CONFIG_RCU_LAZY:
It is still disabled by default. Must specify
rcutree.enable_rcu_lazy and rcu_nocbs=all in boot time parameter to actually enable it.
Link:https://android.googlesource.com/kernel/common/+/61dd43b723d3553a794be6a279ec330db059ea98
[4] CONFIG_RCU_EXPERT, CONFIG_RCU_NOCB_CPU:
Enable configs needed for RCU perf/power optimizations Link:https://android.googlesource.com/kernel/common/+/e9b2f28785260537f78edc901e65592f9e1869af

config: adjust PSI and RCU config
[1] CONFIG_PSI: It has already enabled in x86 and loongarch config,
enable it on arm64 config.
[2] CONFIG_RCU_BOOST:
Config helps to boost the priority of preempted RCU readers that
block the current preemptible RCU grace period for too long.
Enable CONFIG_RCU_BOOST for x86, arm64, loongarch architectures.
Link:https://android.googlesource.com/kernel/common/+/83571e3b13db8d4ce64cc62644b35181125867cf
[3] CONFIG_RCU_LAZY:
It is still disabled by default. Must specify
rcutree.enable_rcu_lazy and rcu_nocbs=all in boot time parameter
to actually enable it.
Link:https://android.googlesource.com/kernel/common/+/61dd43b723d3553a794be6a279ec330db059ea98
[4] CONFIG_RCU_EXPERT, CONFIG_RCU_NOCB_CPU:
Enable configs needed for RCU perf/power optimizations
Link:https://android.googlesource.com/kernel/common/+/e9b2f28785260537f78edc901e65592f9e1869af

Signed-off-by: Wentao Guan <[email protected]>
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 配置项重复添加

    • deepin_arm64_desktop_defconfigdeepin_loongarch_desktop_defconfigdeepin_x86_desktop_defconfig 中,CONFIG_PSI 配置项被重复添加。建议检查是否有遗漏,并确保每个配置项只添加一次。
  2. RCU 配置项

    • CONFIG_RCU_EXPERTCONFIG_RCU_BOOSTCONFIG_RCU_NOCB_CPUCONFIG_RCU_LAZYCONFIG_RCU_LAZY_DEFAULT_OFF 这些配置项在多个架构的配置文件中重复出现。建议确认这些配置项是否必要,并考虑是否可以在一个通用的配置文件中定义,以避免重复。
  3. 配置项的顺序

    • 配置项的顺序在各个文件中可能不一致,建议统一配置项的添加顺序,以提高代码的可读性和一致性。
  4. 配置项的注释

    • 在配置文件中添加适当的注释,解释每个配置项的作用和影响,有助于其他开发者理解配置项的用途。
  5. 配置项的依赖性

    • 确保添加的配置项之间没有依赖关系问题,例如,某些配置项可能需要其他配置项的支持。
  6. 配置项的版本兼容性

    • 确保添加的配置项与当前内核版本兼容,避免引入不兼容的问题。
  7. 配置项的文档更新

    • 如果这些配置项的修改会影响用户或开发者,建议更新相应的文档,说明配置项的变更和影响。

综上所述,建议对配置文件进行全面的审查,确保配置项的正确性、一致性和兼容性,并添加必要的注释和文档。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Collaborator

/lgtm

@opsiff opsiff changed the title deepin: config: adjust PSI and RCU config [Deepin-Kernel-SIG] [linux 6.6-y] deepin: config: adjust PSI and RCU config Jan 6, 2025
@opsiff opsiff merged commit 5eeb6a9 into linux-6.6.y Jan 6, 2025
6 of 10 checks passed
@opsiff opsiff deleted the linux-6.6.y-2025-01-06-config branch January 6, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants