Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Improvements #29

Closed
RaiVaibhav opened this issue Apr 1, 2024 · 2 comments · Fixed by #31
Closed

UX Improvements #29

RaiVaibhav opened this issue Apr 1, 2024 · 2 comments · Fixed by #31
Labels
help wanted Extra attention is needed

Comments

@RaiVaibhav
Copy link

RaiVaibhav commented Apr 1, 2024

Proposed changes

  • Selecting model before initialization, give user an option to select the model?
  • Text area with limited rows instead of input? right now if I press shift+enter then it acts as a enter
  • Maintaining the state of chosen model on refresh?
  • Mobile view fixes: logo image is too big (width wise) for small screen, if text messages are big then it doesn't break into another line?
  • Performance optimization? (check the lighthouse)

Context

Few of my initial findings, while I was on my phone. First thing I noticed after login into the Deepgram that it have different model, but there is no option to choose.

Possible Implementation

Not obligatory, but suggest an idea for implementing addition or change

Other information

I would be happy to contribute.

@lukeocodes
Copy link
Collaborator

  • model selection

on model selection, I'd quite like to have the deepgram connection occur after the app interface has loaded, and show a loading wheel while we connect to the websocket. that way, we can use the settings draw, and on changing model it will show the loading screen again.

hopefully this will give us the benefit of keeping message history while users are allowed to change whichever settings they wish

let's separate this into a separate issue so we can continue to discuss it.

  • text area with limited rows instead of input

love this. would love a PR that maintains the mobile-friendly interface and allows multiple lines of input.

go for it!

  • refreshable state

for settings, yeh this is a great idea. i believe there are some nice solutions out there in the wild for syncing useState with localstorage. useLocalStorage might be done

go for it!

  • mobile fixes

go for it!

  • performance opt

go for it!

@jpvajda jpvajda added the help wanted Extra attention is needed label Apr 2, 2024
RaiVaibhav added a commit to RaiVaibhav/deepgram-conversational-demo that referenced this issue Apr 2, 2024
Relates to deepgram-devs#29
- It fixes accessibility
- Fixes LCP, performance increase from 50 to 70%
@RaiVaibhav
Copy link
Author

Ack, I will create a separate issue for the first issue. 👍

lukeocodes pushed a commit that referenced this issue Apr 10, 2024
* Issue-29: Fix LCP of app

Relates to #29
- It fixes accessibility
- Fixes LCP, performance increase from 50 to 70%

* Fix Text: follow -> share
RaiVaibhav added a commit to RaiVaibhav/deepgram-conversational-demo that referenced this issue Apr 12, 2024
Relates to deepgram-devs#29
- It fixes accessibility
- Fixes LCP, performance increase from 50 to 70%
lukeocodes pushed a commit that referenced this issue May 5, 2024
* fix: LCP of app

Relates to #29
* fix: accessibility

* fix: LCP, performance increase from 50 to 70%

* fix: Fix mobile responsive, store voice

* fix: layout to avoid duplication of MessageAudio

* fix: build failed because of types

* fix: border to 2rem
tauhidulislam100 pushed a commit to PetalC/Deepgram that referenced this issue Sep 10, 2024
* Issue-29: Fix LCP of app

Relates to deepgram-devs/deepgram-ai-agent-demo#29
- It fixes accessibility
- Fixes LCP, performance increase from 50 to 70%

* Fix Text: follow -> share
tauhidulislam100 pushed a commit to PetalC/Deepgram that referenced this issue Sep 10, 2024
* fix: LCP of app

Relates to deepgram-devs/deepgram-ai-agent-demo#29
* fix: accessibility

* fix: LCP, performance increase from 50 to 70%

* fix: Fix mobile responsive, store voice

* fix: layout to avoid duplication of MessageAudio

* fix: build failed because of types

* fix: border to 2rem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants