Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Ensemble dimensions #248

Merged
merged 24 commits into from
Apr 15, 2022

Conversation

theovincent
Copy link
Contributor

This is the new version of the PR #240 with far less commits but the same content. This PR is also rebased on the master branch.

@github-actions github-actions bot added the Type: Documentation Documentation only changes label Apr 6, 2022
@theovincent
Copy link
Contributor Author

@oboulant, @deepcharles are you happy with the example proposed here? :)

@oboulant
Copy link
Collaborator

@oboulant, @deepcharles are you happy with the example proposed here? :)

Minor comments but looks good to me 👍

@deepcharles
Copy link
Owner

Thanks to you both. I added some changes also (mostly about the "story" we want to tell). The diff is a bit messy because I rename the file.

Please tell me if there any typo, otherwise we are good to go.

@oboulant
Copy link
Collaborator

Thanks to you both. I added some changes also (mostly about the "story" we want to tell). The diff is a bit messy because I rename the file.

Please tell me if there any typo, otherwise we are good to go.

I made a final pass ! Good to go on my side ! Indeed, the story telling is better !

Congrats @theovincent and @deepcharles !

@theovincent
Copy link
Contributor Author

I am okay with the changes.

Thank you a lot @deepcharles and @oboulant for reviewing my PR. I learnt a lot :)

@deepcharles deepcharles merged commit 5c6929a into deepcharles:master Apr 15, 2022
@deepcharles deepcharles deleted the ensemble-dimensions branch April 15, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants