-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Ensemble dimensions #248
docs: Ensemble dimensions #248
Conversation
@oboulant, @deepcharles are you happy with the example proposed here? :) |
Minor comments but looks good to me 👍 |
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
Co-authored-by: Olivier Boulant <[email protected]>
for more information, see https://pre-commit.ci
Thanks to you both. I added some changes also (mostly about the "story" we want to tell). The diff is a bit messy because I rename the file. Please tell me if there any typo, otherwise we are good to go. |
I made a final pass ! Good to go on my side ! Indeed, the story telling is better ! Congrats @theovincent and @deepcharles ! |
I am okay with the changes. Thank you a lot @deepcharles and @oboulant for reviewing my PR. I learnt a lot :) |
This is the new version of the PR #240 with far less commits but the same content. This PR is also rebased on the master branch.