Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node exporter #74

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Node exporter #74

merged 4 commits into from
Mar 31, 2022

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented Mar 30, 2022

It installs the binary and its configuration (port 9101by default). Once the package is installed, it is possible to access "http://(VMaddress):9101/metrics" from an explorer on the same network

@jbsv jbsv requested review from pierluca and nkcr March 30, 2022 15:38
@coveralls
Copy link

coveralls commented Mar 30, 2022

Pull Request Test Coverage Report for Build 2069941291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 54.806%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.72%
Totals Coverage Status
Change from base Build 2029730006: -0.2%
Covered Lines: 3079
Relevant Lines: 5618

💛 - Coveralls

export proxy_addr="0.0.0.0:9080"
export prometheus_addr="0.0.0.0:9100"
export node_exporter_addr=":9101"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, I would use 0.0.0.0:9101

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me 👍
Two minor comments:

  • add --collector.systemd option
  • use 0.0.0.0:9101

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

18.9% 18.9% Coverage
0.0% 0.0% Duplication

@nkcr nkcr added the UNICORE label Mar 31, 2022
@jbsv jbsv merged commit 5b35103 into unikernel-combine-shares Mar 31, 2022
@jbsv jbsv deleted the node_exporter branch March 31, 2022 08:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2069878075

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 55.073%

Totals Coverage Status
Change from base Build 2029730006: 0.04%
Covered Lines: 3094
Relevant Lines: 5618

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2069878075

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 55.073%

Totals Coverage Status
Change from base Build 2029730006: 0.04%
Covered Lines: 3094
Relevant Lines: 5618

💛 - Coveralls

ineiti pushed a commit that referenced this pull request Oct 10, 2024
test: add missing skip instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants