-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node exporter #74
Node exporter #74
Conversation
Pull Request Test Coverage Report for Build 2069941291
💛 - Coveralls |
export proxy_addr="0.0.0.0:9080" | ||
export prometheus_addr="0.0.0.0:9100" | ||
export node_exporter_addr=":9101" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency, I would use 0.0.0.0:9101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me 👍
Two minor comments:
- add
--collector.systemd
option - use
0.0.0.0:9101
Kudos, SonarCloud Quality Gate passed! |
Pull Request Test Coverage Report for Build 2069878075Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 2069878075Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
test: add missing skip instructions
It installs the binary and its configuration (port 9101by default). Once the package is installed, it is possible to access "http://(VMaddress):9101/metrics" from an explorer on the same network