Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates memcoin to have automatic setup #65

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Updates memcoin to have automatic setup #65

merged 1 commit into from
Mar 17, 2022

Conversation

nkcr
Copy link
Contributor

@nkcr nkcr commented Mar 17, 2022

  • with the --postinstall option when running memcoin start, the CLI will automatically start and initializes its services
  • also fixes the Neff handler to sync the manager in case it can't send the transaction to the pool

- with the `--postinstall` option when running `memcoin start`, the CLI will automatically start and initializes its services
- also fixes the Neff handler to sync the manager in case it can't send the transaction to the pool
@nkcr nkcr self-assigned this Mar 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

6.1% 6.1% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Mar 17, 2022

Pull Request Test Coverage Report for Build 1998405893

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 29 (27.59%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 54.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/dkg/pedersen/controller/action.go 0 1 0.0%
services/dkg/pedersen/controller/mod.go 0 1 0.0%
services/shuffle/neff/controller/mod.go 1 3 33.33%
contracts/evoting/controller/mod.go 0 4 0.0%
contracts/evoting/controller/action.go 0 6 0.0%
services/shuffle/neff/handler.go 3 10 30.0%
Files with Coverage Reduction New Missed Lines %
contracts/evoting/controller/action.go 1 0.0%
Totals Coverage Status
Change from base Build 1979440505: 0.1%
Covered Lines: 3004
Relevant Lines: 5487

💛 - Coveralls

@nkcr
Copy link
Contributor Author

nkcr commented Mar 17, 2022

@pierluca @jbsv I'm merging as is. Can be review in postmortem.

@nkcr nkcr merged commit dd989f7 into main Mar 17, 2022
@nkcr nkcr deleted the postinstall-command branch March 17, 2022 12:05
ineiti pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants