Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meeting notes for week1 meeting #173

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

chenchanglew
Copy link
Contributor

Meeting Notes for security auditing 22/09/2022

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Sep 22, 2022

Pull Request Test Coverage Report for Build 3122335970

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.5%

Totals Coverage Status
Change from base Build 3103604593: 0.0%
Covered Lines: 2364
Relevant Lines: 4041

💛 - Coveralls

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Some minor comments:

  • Make sure to accept the CLA by clicking on the link (see the comment)
  • Please name the file week-1-security-audit.md.
  • Nit pick, but add an empty line after and before titles
  • Add the date in the document. This is also a good practice to mention who were present in the meeting.

@chenchanglew
Copy link
Contributor Author

Thank you !

Some minor comments:

  • Make sure to accept the CLA by clicking on the link (see the comment)
  • Please name the file week-1-security-audit.md.
  • Nit pick, but add an empty line after and before titles
  • Add the date in the document. This is also a good practice to mention who were present in the meeting.

All the comments have been resolved thanks :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nkcr nkcr merged commit dfe36b3 into main Sep 26, 2022
@nkcr nkcr deleted the meeting-notes/security-auditing-22092022 branch September 26, 2022 09:15
ineiti pushed a commit that referenced this pull request Oct 10, 2024
feat: hide elections on blocklist
@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 3122335970

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.5%

Totals Coverage Status
Change from base Build 3103604593: 0.0%
Covered Lines: 2364
Relevant Lines: 4041

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants