Frontend admin #135
Merged
Frontend admin #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2433813907Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nkcr
reviewed
Jun 3, 2022
| @@ -18,7 +19,7 @@ type AddAdminUserModalProps = { | |||
| handleAddRoleUser(user: object): void; | |||
| }; | |||
|
|
|||
| const roles = ['Admin', 'Operator']; | |||
| @@ -0,0 +1,179 @@ | |||
| import React, { FC, Fragment, useContext, useEffect, useRef, useState } from 'react'; | |||
There was a problem hiding this comment.
Modals specific to the admin page should be placed in /pages/admin/components
|
|
||
| const response = await sendFetchRequest(endpoints.editProxyAddress(node), req, setIsPosting); | ||
|
|
||
| if (response) { |
There was a problem hiding this comment.
It seems that the user won't be notified if it fails.
There was a problem hiding this comment.
I used the usePostCall hook, which takes setPostError as argument, and then if there's an error it's displayed in a flash message using a useEffect with postError as a dependency
|
Kudos, SonarCloud Quality Gate passed! |
nkcr
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the table of the nodes and their associated proxy address to the Admin page.