-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the project packageable #59
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8794a33
Rename the "pydecred" subpackage to "dcr" and use relative imports.
teknico 73da96b
Moved the library files to a new "decred" package.
teknico 4a5503e
Temp. fix for the Github Action def. file
teknico 5aef2b8
Relative imports never go up.
teknico 8336d96
Complete the decred package's pyproject.toml file.
teknico 2710c72
Create the tinywallet package and make it installable.
teknico 1cab109
Changes per review:
teknico 1a4dc04
Update the Github action to use the poetry tool
teknico 997c99c
Update the documentation.
teknico fb539ff
Changes per review:
teknico 05311c1
Do not run Black under Python 3.5 in the PR checks.
teknico 11517af
Remove support for Python 3.5. Update the two pyproject.toml files too.
teknico 262bffb
Update the tinywallet dependencies and its lock file.
teknico fde4224
Update both pyproject.toml files as per review.
teknico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
examples/testnet | ||
decred/dist | ||
tinywallet/dist | ||
decred/poetry.lock | ||
__pycache__/ | ||
.pytest_cache | ||
.coverage | ||
.venv | ||
*.egg-info | ||
*.sublime-project | ||
*.sublime-workspace | ||
examples/testnet | ||
.coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Contribution guidelines | ||
|
||
Thank you for contributing to this project! The developers are part of the | ||
[Decred community](https://decred.org/community/) and coordinate in a | ||
[chat](https://chat.decred.org/#/room/#tinydecred:decred.org) on the | ||
[Matrix](https://matrix.org/) platform, you'll need a (free) account to access | ||
it. | ||
|
||
## Bugs and new features | ||
|
||
If you found a bug, before creating an issue please search among the | ||
[open ones](https://github.com/decred/tinydecred/issues). Please add as many | ||
useful details as you can. | ||
|
||
If you'd like to request a new feature, either create an issue (again, after | ||
searching first) or, preferably, discuss your request with the developers as | ||
mentioned above. | ||
teknico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Development | ||
|
||
This project is managed via the [Poetry](https://python-poetry.org/) tool. | ||
teknico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
You'll reformat your changes with the [Black](https://black.readthedocs.io/) | ||
tool and run tests using [pytest](https://www.pytest.org/). | ||
|
||
Before each pull request is merged, a Github workflow action is run to make | ||
sure that the changes meet some minimum requirements. The action definition | ||
[file](./.github/workflows/python.yml) is a useful summary of the commands | ||
you'll run while developing. | ||
|
||
## More information | ||
|
||
Please find more information in the dcrd | ||
[contribution guidelines](https://github.com/decred/dcrd/blob/master/docs/code_contribution_guidelines.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you're not ignoring the tinywallet/poetry.lock. Is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, well spotted.
tinywallet/poetry.lock
is indeed committed,decred/poetry.lock
is not. The idea is to commit lock files for applications, but not for libraries.You want to commit the lock file for apps so that a build always uses the same versions of the dependencies (and their dependencies), and therefore is reproducible.
You don't want to commit the lock file for libraries because then you would have multiple lock files for different libraries and for the app that uses them, potentially conflicting among them.
The libraries will specify the version intervals for their dependencies in their
pyproject.toml
orrequirements.txt
files; Poetry will respect those intervals, but will disregard any libraries' lock files. The only lock file that counts is the app one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably nothing, but using the provided
tinywallet/poetry.lock
file threw an error at me:Running poetry update solved the problem, but it gave me a rather large diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, forgot to update the dependencies and the lock file. Thanks.