-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive Settings and Transaction Details #2215
Responsive Settings and Transaction Details #2215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
In the next ones, try to keep one issue per PR (unless they are very related, like #2000 and #2201) because it is easier to review.
The settings part LGTM.
On tx detail page, I notice the to address and tx fee is missing when tx is pending
Also the tx address is missing in the confirmed ones
Thank you for the review. Sorry for the multi-issue PR, I won't do that again. I think on the screenshot there is no Meanwhile, I find an issue with the header. It has a fixed height and it did not increase properly. Now it is corrected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the fixed header height bug.
You are right about the pending transaction, but we have the output addresses at tx. Can you add them to the headers?
Also #2222 made me realize that the save button is not showing at the screen in smaller width. Can you fix that, as well? |
I am on the I think this PR already solve #2222. At least I can not reproduce it. |
Yeah, I noticed. You brought some master's commits to your PR. Can you rebase it? |
72748fb
to
22a1eb4
Compare
I've rebased it and added the output addresses. |
Please try it now. |
Thanks, it looks fine now. I have just one more comment. Can you edit this PR so the issues close when merging it? When writing in topics like that, github doesn't close the issues when merging the PR. From github documentation: |
Sure. I edited it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please resolve these conflicts and then it should be good to go. |
6fc9815
to
722cc5d
Compare
This closes #1951, closes #2000, and closes #2201