Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive views: Help - Sources/Tutorials/Logs #2202

Merged
merged 8 commits into from
Oct 16, 2019
Merged

Responsive views: Help - Sources/Tutorials/Logs #2202

merged 8 commits into from
Oct 16, 2019

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Oct 8, 2019

Closes #2001

vctt94
vctt94 requested changes Oct 9, 2019
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. It looks good overall, I have only a couple comments.

In the tutorial screen the previous button looks too close from the image, so I think it may be hard to click. Maybe it would be better if they were side to side
image

@bgptr
Copy link
Collaborator Author

bgptr commented Oct 9, 2019

Thanks for the review. I fixed your reviews comments.

vctt94
vctt94 reviewed Oct 11, 2019
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing my comments.

I added a couple more

@bgptr
Copy link
Collaborator Author

bgptr commented Oct 11, 2019

Thanks for the review. I fixed your reviews comments.

matheusd
matheusd reviewed Oct 11, 2019
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine overall. Only a nit: at the smallest screen width I cannot click on the next/previous buttons (the bottom bar is fixed on top of them).

@bgptr
Copy link
Collaborator Author

bgptr commented Oct 11, 2019

@matheusd: good catch, thanks! I tweaked it a little bit.

matheusd
matheusd approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

vctt94
vctt94 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexlyp
Copy link
Member

alexlyp commented Oct 16, 2019

Needs a quick conflict resolved, then can be merged.

@alexlyp alexlyp merged commit 77b655b into decred:master Oct 16, 2019
@bgptr bgptr deleted the responsive_help branch October 17, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

@vctt94 vctt94 vctt94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Responsive views: Help - Sources/Tutorials/Logs
4 participants
@bgptr @alexlyp @matheusd @vctt94