Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh.json #588

Closed
wants to merge 1 commit into from
Closed

Update zh.json #588

wants to merge 1 commit into from

Conversation

DominicTing
Copy link
Contributor

Modified the translation of some Chinese grammars and revised the Chinese translation of some professional terms. These changes make it easier for people to understand.The existing Chinese translation looks a bit bad, and some of the descriptions seem confusing.I modified them:)

Modified the translation of some Chinese grammars and revised the Chinese translation of some professional terms. These changes make it easier for people to understand.The existing Chinese translation looks a bit bad, and some of the descriptions seem confusing.
@dajohi dajohi requested a review from peterzen March 7, 2019 19:31
Copy link
Member

@peterzen peterzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test suite runs correctly

Copy link
Member

@peterzen peterzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this isn't the master translation file, it needs to be converted to the master in order for the changes to not get lost in the next Transifex update. Please run this command and make sure your changes are visible in transifex_catalogs/zh.json.
jq 'map( { (.id): .translation } ) | add' src/i18n/zh.json > transifex_catalogs/zh.json

@Guang168
Copy link
Member

Guang168 commented Mar 8, 2019

Whats the procedure to add new users to transifex and make changes from there ?
Maybe some std steps for people to suggest changes to wordings/translations on web/doc/decrediton/android/ios ? Add a simple guide into dcrdocs maybe ?

@peterzen
Copy link
Member

peterzen commented Mar 8, 2019

Users have to be manually added to TF at the moment, there's no way to automate this unfortunately. So far the process has been that people who volunteered for reviews showed up in the #dev channel and then I added them - but this is certainly not the best way to go about it. Perhaps a few more people could be registered as project maintainers and then they could manage reviewers when they show up, this would certainly be good to have documented in dcrdocs.

peterzen added a commit to peterzen/dcrweb that referenced this pull request Mar 13, 2019
@peterzen peterzen mentioned this pull request Mar 13, 2019
peterzen pushed a commit to peterzen/dcrweb that referenced this pull request Mar 13, 2019
Modified the translation of some Chinese grammars and revised the Chinese translation of some professional terms. These changes make it easier for people to understand.The existing Chinese translation looks a bit bad, and some of the descriptions seem confusing.
peterzen pushed a commit to peterzen/dcrweb that referenced this pull request Mar 13, 2019
Modified the translation of some Chinese grammars and revised the Chinese translation of some professional terms. These changes make it easier for people to understand.The existing Chinese translation looks a bit bad, and some of the descriptions seem confusing.
peterzen added a commit to peterzen/dcrweb that referenced this pull request Mar 14, 2019
@dajohi
Copy link
Member

dajohi commented Mar 14, 2019

Closed by #597

@dajohi dajohi closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants