Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /press to /news #1084

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Change /press to /news #1084

merged 9 commits into from
Oct 10, 2022

Conversation

jholdstock
Copy link
Member

  1. Rename "Press" to "News" (Closes Add News header link #1079)
    • Change URL from /press to /news and add redirect.
    • Add link to /News in header navbar.
    • Use "News" instead of "Coverage" and "Press".
  2. Add /vsp link to footer (Closes No link to /vsp on home #1078)
  3. Fix overlapping text and buttons on AR press page. (Closes /press doesnt work properly on RTL language #1077)
  4. Add loads of news posts.
    • Software releases for decred and dcrdex
    • Articles/interviews from binance.com, coindesk.com and cointelegraph.com (and others)
  5. Fix a bug where news posts were not being sorted by date

@jholdstock
Copy link
Member Author

Hey @xaur,

Pinging you as somebody with a keen eye for detail - these two commits add a bunch of news/press/interviews etc. Was hoping you could take a look and sanity check, make sure there is nothing too negative or controversial there.

4edc283
fdc42a3

Thanks!

@xaur
Copy link
Contributor

xaur commented Sep 26, 2022

Nice job digging out all these items to give News the weight it deserves! Software releases is a must have on the News page. Also, we definitely want better exposure for the awesome blog.decred.org content.

Re fdc42a3 and 4edc283:

I could not re-read everything but used a quick heuristic. I grepped each added link in DJ and if we included it there's a very high chance it was sane (esp. if it was secured by Monde PR).

  • The Wikipedia post on Decrypt was mildly controversial but so was the WP behavior it covered so I'd keep it.

  • The two posts on binance.com and one at crowdfundinsider.com missed by DJ are sane (mostly forward our Twitter ANNs). I wish we had proper news at decred.org for such events as most FOSS projects do, so these outlets quite helped there.

If you ever need to check a link like this, you can grep a local clone of decred-news repo or even exploit the web search (example). Second source is the sheet of media coverage secured by Monde PR - it was just recently updated (e.g. Ctrl-F 182204). This is not a way to say "Don't ping me!" - please do, I'm willing to help with reviews! Just sharing a tool if you need a quick check a link without blocking on anyone.

@@ -193,6 +493,14 @@
sortDate: "2020-09-12"
icon: "dcrInMedia.svg"
externalSource: "medium.com/decred/journals/home"
-
Title: "Decred Release v1.5.2"
Author: "David Hill"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if jrick was building those earlier releases too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, I just went with the name of whoever published the release on github, which doesnt necessarily correspond with who did the build.

"press_releases": "Releases",
"news_title": "News",
"news_description": "Decred has been prominently featured by The Wall Street Journal, Forbes, Bitcoin Magazine and many more. Below is a sampling of recent coverage.<br /><br />To get in touch with Decred, contact <a href=\"mailto:[email protected]\">[email protected]</a>",
"news_press_releases": "Releases",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Releases" is easy to confuse with "Software Releases". I'd use "Press" or "Press Releases" to avoid that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I didnt change it because we already have translated strings in every language for "Releases" and we don't have any for "Press Releases"

@@ -11,7 +11,8 @@
<div class="col-12 col-xl-3">
<div class="d-flex flex-row flex-wrap flex-xl-column align-items-start">
<a class="footer-link" href="{{ "/brand/" | relLangURL }}">{{ T "nav_brand_resources" }}</a>
<a class="footer-link" href="{{ "/press/" | relLangURL }}">{{ T "nav_in_the_press" }}</a>
<a class="footer-link" href="{{ "/news/" | relLangURL }}">{{ T "nav_in_the_press" }}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will translate to "Decred in the Press" (in English). /news will be a mix of own news, own press releases and 3rd party media coverage so maybe the footer link needs a change to reflect that. How about "News" or "News and Press"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most flexible solution would be to have two footer links "News" and "Press" where "Press" sends to /news/#press and that anchor flips the toggle to only show Press. But it may need some JS so maybe we don't need that for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the footer "Decred in the Press" link with just "News"

@xaur
Copy link
Contributor

xaur commented Sep 26, 2022

I wonder how the News / Press toggle will work now and how it should work. Are press releases shown by default (mixed with everything else) or only after clicking Press?

The way I imagine it is all content (of different "types") could be shown by default to expose everything, and then we'd have a 3 position toggle/slider like All | Software | Press that only keep that type of items. May be an idea for future PRs, just looking to discuss.

@jholdstock
Copy link
Member Author

Adding to the considerations above, we are also getting to a point where the list is so long that a filter on dates may be needed (perhaps 2022/2021/2020...?)

@jholdstock
Copy link
Member Author

Continuously adding new News articles is a pain, and given how out of date the list was before this PR, it is obviously it is a job which doesn't have an owner.

Given that there is already a monthly dcrweb PR to add the latest DJ, could that workflow be expanded to also add the relevant news articles for the month?

@jholdstock
Copy link
Member Author

One more thing came to mind whilst working on this - I think DJ deserves its own icon. Do you have anything?

@xaur
Copy link
Contributor

xaur commented Sep 27, 2022

we are also getting to a point where the list is so long that a filter on dates may be needed (perhaps 2022/2021/2020...?)

That would work. Numeric pages (1, 2, 3, ...) would work too. An alternative I've seen elsewhere is to only show last N items on News and move everything else to All News page. The latter will be a less used page for those willing to dig the history.

I think DJ deserves its own icon. Do you have anything?

I guess it does, but I don't have any icon for it. Sorry.

@xaur
Copy link
Contributor

xaur commented Sep 27, 2022

Continuously adding new News articles is a pain, and given how out of date the list was before this PR, it is obviously it is a job which doesn't have an owner.

Yes it is routine. I think it is a routine that really should be done though. Many FOSS projects continuously add news on their sites and I think it's a good practice to follow.

To be honest, I think decred.org/news should be our primary ANN target since we have better control of it compared to Twitter, which is currently the de facto project's news feed. We just didn't have this discussion before an explicit News page.

Just a link+title+author is a good start, but ideally we should have a system for small news posts like we have for Press releases. But that's a topic for future PRs.

Given that there is already a monthly dcrweb PR to add the latest DJ, could that workflow be expanded to also add the relevant news articles for the month?

Yeah we can try this for September. It will be only monthly updates but it's better than no updates.

@jholdstock
Copy link
Member Author

@jzbz has also given his approval to the added news articles (on Matrix).

@jzbz
Copy link
Member

jzbz commented Sep 28, 2022

@jzbz has also given his approval to the added news articles (on Matrix).

Yes +1.

@xaur
Copy link
Contributor

xaur commented Oct 8, 2022

If it looks cluttered maybe also rename Documentation to Docs in the top nav header. Or keep it as is and we'll see how it looks.

- Change URL from /press to /news and add redirect.
- Add link to /News in header navbar.
- Use "News" instead of "Coverage" and "Press".
Includes Software releases and articles from binance.com, coindesk.com and cointelegraph.com.
@dajohi dajohi merged commit d435309 into decred:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add News header link No link to /vsp on home /press doesnt work properly on RTL language
4 participants