multi: allow wallet unlocks via a passphrase token. #1437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
changed the title
dnldd
force-pushed
the
priv_pass_token
branch
2 times, most recently
from
2dc5010 to
68e2526
Compare
This updates the grpc interceptor to accept private passphrases set in context metadatas. When set the private passphrase takes precedence over the optional request passphrase field.
|
This isn't the solution I had in mind. The goal for adding authentication to the gRPC server is that authenticated clients that do not have the passphrase are still able to use private keys and sign transactions, with the passphrase being provided by a different, isolated and secure client. Discussed in a matrix DM about ideas for how authentication should occur. A simple user/password could work, but I think it's also a good idea to begin working on using tls client auth certificates as a more secure means of authentication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the grpc interceptor to accept private passphrases set in context metadatas. When set
the private passphrase takes precedence over the optional request passphrase field.
This resolves #1316.