harness: Update eth to work with geth 1.14 and up. #3123

JoeGruffins · 2024-12-18T12:01:55Z

Also no longer using the deprecated personal namespace

JoeGruffins · 2024-12-19T12:28:38Z

Does polygon need all the same changes?

JoeGruffins · 2024-12-20T09:23:44Z

dex/testing/btc/base-harness.sh

@@ -114,7 +114,7 @@ tmux send-keys -t $SESSION:0 "${DAEMON} -rpcuser=user -rpcpassword=pass \
  -rpcport=${ALPHA_RPC_PORT} -datadir=${ALPHA_DIR} $(deprecateddbd $ALPHA_DESCRIPTOR_WALLET) \
  -debug=rpc -debug=net -debug=mempool -debug=walletdb -debug=addrman -debug=mempoolrej \
  -whitelist=127.0.0.0/8 -whitelist=::1 \
-  -txindex=1 -regtest=1 -port=${ALPHA_LISTEN_PORT} -fallbackfee=0.00001 \


On Bitcoin core v28.0.0 for some reason this wasn't using the port anymore. Using bind seems to work...

Just tried bitcoin core v22-1 and it accepts -bind=12345 but does not make a listening tcpip port.

2024-12-25T07:55:25Z Command-line arg: bind="12345" 2024-12-25T07:55:25Z Command-line arg: server="1"

netstat -tl <- no new port. i.e. it fails silently!

-port=12345 does make port:

tcp 0 0 0.0.0.0:12345 0.0.0.0:* LISTEN tcp6 0 0 [::]:12345 [::]:* LISTEN

So -bind does not work on earlier versions?

Cannot say all earlier but I suspect so

Just did a quiick search on bitcoin and it looks a bit more complex ..

I'll try just setting both...

JoeGruffins · 2024-12-20T09:25:56Z

I was going to update the internal eth nodes, but its adding a toolchain to the go.mod and we didn't want that for some reason. I guess we will have to add it to update though?

JoeGruffins · 2024-12-24T09:39:10Z

The harness just mines whenever there is a transaction, which is unfortunate, but the mining scrip needs to be updated to reflect this. Also some tests in /client/asset/eth are broken still.

JoeGruffins · 2024-12-25T06:13:50Z

Fixing the mining script https://github.com/decred/dcrdex/compare/726f473c18811544c6624b9239ddb78b555fe86f..b983ef294ec3571e685b9751863fc5de947ab172

I also tried setting --dev.period 10 but for some reason no transactions are mined then. That may be useful for testing if we can figure it out.

JoeGruffins · 2024-12-25T09:14:47Z

Fixing tests and apparently gas for token swaps is less now https://github.com/decred/dcrdex/compare/b983ef294ec3571e685b9751863fc5de947ab172..4f832ebf1086d67112a0cae15b7c3a55c65032ae

Also, I had to update to 1.14.12 because HeaderByNumber was returning an incorrect header on simnet.

JoeGruffins · 2025-02-03T07:33:33Z

It looks like the newest version 1.14.13 does not require the toolchain thing to go.mod

JoeGruffins · 2025-02-03T07:42:50Z

It looks like we must have go 1.22 though https://github.com/decred/dcrdex/compare/ef12c81a71930dd3b6bdf99fa997808390a0a738..758821247746b64667e366415276f05270ef6b9c

martonp

I tried --dev.period and it worked for me: b6ba4cd

I removed the mine-alpha script as well, since the mining is automatically handled by geth. The only issue I had was that it would only mine one transaction per block, and I'm not sure why. The gas ceiling is higher than all of the pending transactions.

martonp · 2025-02-04T16:19:59Z

client/asset/eth/eth_test.go

-		if info.MaxSwapsInTx != 20 {
-			t.Fatalf("expected 20 for max swaps but got %d", info.MaxSwapsInTx)
+		if info.MaxSwapsInTx != 24 {
+			t.Fatalf("expected 24 for max swaps but got %d", info.MaxSwapsInTx)
 		}
-		if info.MaxRedeemsInTx != 45 {
-			t.Fatalf("expected 45 for max redemptions but got %d", info.MaxRedeemsInTx)
+		if info.MaxRedeemsInTx != 55 {
+			t.Fatalf("expected 55 for max redemptions but got %d", info.MaxRedeemsInTx)


Why did these change?

The values are different with the changes.

Heads up that #2038 removes these fields from WalletInfo and we calculate them dynamically instead.

dex/networks/eth/params.go

server/asset/eth/eth.go

dex/networks/erc20/contracts/TestToken.sol

martonp · 2025-02-04T16:42:10Z

dex/testing/eth/harness.sh

+
+    function setSenderBalance (tokenAddr, amt) {
+      var testToken = contract.at(tokenAddr)
+      return testToken.setSenderBalance(amt*1000000)


Maybe in some contract the decimal will not be 6. You could check the decimals in the contract and multiply based on that.

Taking out the conversion so the caller can do it. Hope thats good enough.

dex/testing/eth/harness.sh

JoeGruffins · 2025-02-06T06:23:27Z

I tried --dev.period and it worked for me: b6ba4cd

I removed the mine-alpha script as well, since the mining is automatically handled by geth. The only issue I had was that it would only mine one transaction per block, and I'm not sure why. The gas ceiling is higher than all of the pending transactions.

Yeah there was some reason the dev.period didnt work out, I think that's why. We can't work with one tx per block can we?

JoeGruffins · 2025-02-06T09:20:08Z

Reverted the test contract changes, fix most of martons review topics, also removing mining from the loadbot setup. The extra mining seems to be causing problems for geth and its not necessary in my opinion. https://github.com/decred/dcrdex/compare/a9b7a67d37daa752b7849579eb4c22e9aaf9ee22..6c261a4d1b727e0cfe0ba869a5814760eb600cdd

Still using the mining script in the eth harness because we can't do with slow transactions. I guess it is mining one block per transaction though, now, so its a bit unnatural still.

martonp · 2025-02-06T14:11:38Z

Yeah there was some reason the dev.period didnt work out, I think that's why. We can't work with one tx per block can we?

I think it's fine, generally we won't have more than 1 tx per block, and it's more realistic than immediately mining a block only when there is a transaction. I'm pretty sure we're doing something wrong though.. I don't think dev.period would have this restriction. I've messed with the gas ceiling and wasn't able to get it to work.

JoeGruffins · 2025-02-07T02:52:30Z

The loadbot will produce many txn per second, and I use that alot. We can always adjust the scripts manually to meet our needs I suppose. I will look into if I am implementing this wrong. I haven't found anything yet about it only being 1 tx per block googling around. Unsure yet if that's by design.

JoeGruffins · 2025-02-07T09:54:22Z

There`s some time dilation going on. The longer the dev node runs, the further the header's time drifts into the future. This means any contracts based off of local time will eventually be expired before created based on the chain's time. May be due to the fast blocks.

Prints from where we watch blocks:

block 92 header time 2025-02-07 18:36:28 +0900 JST my time 2025-02-07 18:35:27.463838776 +0900 JST
block 829 header time 2025-02-07 18:49:14 +0900 JST my time 2025-02-07 18:45:22.460241287 +0900 JST

JoeGruffins · 2025-02-07T09:57:32Z

dex/testing/loadbot/mantle.go

@@ -71,6 +72,7 @@ func runTrader(t Trader, name string) {
 	}

 	maintain := true
+	time.Sleep(time.Second * 16) // at least a block for reg funds


Need to also listen for ctx.Done here

JoeGruffins force-pushed the updateethharness branch from 401f927 to bc85cd5 Compare December 19, 2024 12:12

dev-warrior777 approved these changes Dec 19, 2024

View reviewed changes

JoeGruffins force-pushed the updateethharness branch 3 times, most recently from b5883f0 to f8ce2cf Compare December 20, 2024 09:22

JoeGruffins commented Dec 20, 2024

View reviewed changes

JoeGruffins marked this pull request as ready for review December 20, 2024 09:24

JoeGruffins force-pushed the updateethharness branch from f8ce2cf to 726f473 Compare December 23, 2024 09:52

JoeGruffins force-pushed the updateethharness branch from 726f473 to b983ef2 Compare December 25, 2024 06:12

JoeGruffins force-pushed the updateethharness branch 2 times, most recently from e9173f2 to 4f832eb Compare December 25, 2024 09:07

JoeGruffins force-pushed the updateethharness branch from 4f832eb to ed3f534 Compare January 15, 2025 04:41

JoeGruffins force-pushed the updateethharness branch from ed3f534 to cdc734b Compare January 24, 2025 04:44

dev-warrior777 approved these changes Jan 24, 2025

View reviewed changes

JoeGruffins force-pushed the updateethharness branch 2 times, most recently from 7469a1d to ef12c81 Compare February 3, 2025 07:32

JoeGruffins force-pushed the updateethharness branch from ef12c81 to 7588212 Compare February 3, 2025 07:42

JoeGruffins requested a review from martonp February 4, 2025 00:34

martonp reviewed Feb 5, 2025

View reviewed changes

JoeGruffins force-pushed the updateethharness branch 2 times, most recently from a9b7a67 to 6c261a4 Compare February 6, 2025 09:16

JoeGruffins added 3 commits February 7, 2025 16:53

harness: Update eth to work with geth 1.14 and up.

b7082b0

harness/btc: Bind to address.

45d0659

client: Update geth import to v1.14.13.

b86aacf

JoeGruffins force-pushed the updateethharness branch from 6c261a4 to b86aacf Compare February 7, 2025 08:04

JoeGruffins marked this pull request as draft February 7, 2025 09:41

JoeGruffins commented Feb 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

harness: Update eth to work with geth 1.14 and up. #3123

harness: Update eth to work with geth 1.14 and up. #3123

JoeGruffins commented Dec 18, 2024 •

edited

Loading

JoeGruffins commented Dec 19, 2024

JoeGruffins Dec 20, 2024

dev-warrior777 Dec 25, 2024 •

edited

Loading

JoeGruffins Feb 3, 2025

dev-warrior777 Feb 4, 2025

dev-warrior777 Feb 4, 2025

JoeGruffins Feb 5, 2025

JoeGruffins commented Dec 20, 2024

JoeGruffins commented Dec 24, 2024

JoeGruffins commented Dec 25, 2024

JoeGruffins commented Dec 25, 2024

JoeGruffins commented Feb 3, 2025

JoeGruffins commented Feb 3, 2025

martonp left a comment

martonp Feb 4, 2025

JoeGruffins Feb 6, 2025 •

edited

Loading

buck54321 Feb 6, 2025

martonp Feb 4, 2025

JoeGruffins Feb 6, 2025

JoeGruffins commented Feb 6, 2025

JoeGruffins commented Feb 6, 2025 •

edited

Loading

martonp commented Feb 6, 2025

JoeGruffins commented Feb 7, 2025

JoeGruffins commented Feb 7, 2025

JoeGruffins Feb 7, 2025

harness: Update eth to work with geth 1.14 and up. #3123

Are you sure you want to change the base?

harness: Update eth to work with geth 1.14 and up. #3123

Conversation

JoeGruffins commented Dec 18, 2024 • edited Loading

JoeGruffins commented Dec 19, 2024

Choose a reason for hiding this comment

dev-warrior777 Dec 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Dec 20, 2024

JoeGruffins commented Dec 24, 2024

JoeGruffins commented Dec 25, 2024

JoeGruffins commented Dec 25, 2024

JoeGruffins commented Feb 3, 2025

JoeGruffins commented Feb 3, 2025

martonp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Feb 6, 2025

JoeGruffins commented Feb 6, 2025 • edited Loading

martonp commented Feb 6, 2025

JoeGruffins commented Feb 7, 2025

JoeGruffins commented Feb 7, 2025

Choose a reason for hiding this comment

JoeGruffins commented Dec 18, 2024 •

edited

Loading

dev-warrior777 Dec 25, 2024 •

edited

Loading

JoeGruffins Feb 6, 2025 •

edited

Loading

JoeGruffins commented Feb 6, 2025 •

edited

Loading