btc: estimatesmartfee in economical mode. #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conservative mode is known to massively overestimate transaction fees, and while economical mode still has issues and still overestimates, its not nearly as extreme.
buck54321
approved these changes
Oct 18, 2024
buck54321
pushed a commit
that referenced
this pull request
Oct 18, 2024
Conservative mode is known to massively overestimate transaction fees, and while economical mode still has issues and still overestimates, its not nearly as extreme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conservative mode is known to massively overestimate transaction fees, and while economical mode still has issues and still overestimates, its not nearly as extreme.
I'm new on this repo so not totally aware of the ramifications of this, but opening this PR for awareness/discussion. My understanding is that the server mandates fee rates for swap txns, so this change should only affect clients when calculating their redeem transactions (which are not as sensitive to timely mining)
References:
bitcoin/bitcoin#30275
https://delvingbitcoin.org/t/bitcoind-policy-estimator-modes-analysis/964