mm: Fix multi split option related bugs #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi split option was not available on BTC clones. Also, the multi split buffer option was available on base assets, but it should only be available for quote assets.
The max fee rate can change at any time and will be changing more often starting with v1. An increase in max fee rate on an asset would make existing sized utxos too small. It will likely be still worth it to have <= 1% buffer on the base asset. You can leave it how you have it for now. I'm planning on redoing the multisplit stuff so that it doesn't use |
buck54321
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi split option was not available on BTC clones. Also, the multi split buffer option was available on base assets, but it should only be available for quote assets.