mm: allocate for redemptions when fee asset mismatch #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
utxo-to-evm-redemption-fee-alloc
branch
2 times, most recently
from
bb844fd to
ea5a479
Compare
martonp
reviewed
Jul 13, 2024
martonp
reviewed
Jul 15, 2024
buck54321
force-pushed
the
utxo-to-evm-redemption-fee-alloc
branch
2 times, most recently
from
eae3899 to
eb26483
Compare
buck54321
commented
Jul 15, 2024
Comment on lines
+1017
to
+1013
| const baseBookingFees = (baseBookingFeesPerLot * baseLots) * baseReservesFactor | ||
| const baseRedeemFees = (baseRedeemReservesPerLot * quoteLots) * quoteReservesFactor | ||
| const quoteBookingFees = (quoteBookingFeesPerLot * quoteLots) * quoteReservesFactor | ||
| const quoteRedeemFees = (quoteRedeemReservesPerLot * baseLots) * baseReservesFactor |
There was a problem hiding this comment.
I'm scaling the booking fees to reserve for the order reserves as well, because the fees reserved for an order are not necessarily released as soon as the order matches. But for the maker, the fees reserved for the swap actually should be released immediately, since the maker should broadcast its swap right away. And since for arb-mm, we usually expect to be the maker, we should maybe only scale the fees reserved for redemptions. I'm gonna leave it for now though, since it's not actually impossible that we'd be the taker.
buck54321
force-pushed
the
utxo-to-evm-redemption-fee-alloc
branch
from
eb26483 to
41a9473
Compare
martonp
reviewed
Jul 16, 2024
martonp
reviewed
Jul 18, 2024
buck54321
force-pushed
the
utxo-to-evm-redemption-fee-alloc
branch
from
41a9473 to
d4d07ac
Compare
buck54321
force-pushed
the
utxo-to-evm-redemption-fee-alloc
branch
from
9cfc7d5 to
50be3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't properly reserving redemption fees for evm assets when the counter-asset didn't share a fee asset.