multi: enforce a minimum market rate that avoids dust redemption outputs #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
reviewed
Jan 31, 2024
JoeGruffins
approved these changes
Feb 7, 2024
client/core/core.go
Outdated
Comment on lines
6282
to
6415
| if rate < mktConf.MinimumRate { | ||
| return nil, newError(orderParamsErr, "order's rate is lower than market's minimum rate. %d < %d", rate, mktConf.MinimumRate) | ||
| } |
There was a problem hiding this comment.
nit: Can the rate be formatted differently. Is it possible to show price? Can be hard to read with all the zeros.
buck54321
force-pushed
the
minmarketrate
branch
from
72d62fd to
ea960ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #2669. This is the diff you're looking for.