erc20: Add testnet usdc. #1733

JoeGruffins · 2022-07-26T10:02:25Z

Contract tests passing but some other's are not. Will update this comment at some point.

~~depends on #1622~~
~~depends on #1832~~
closes #1724

chappjc · 2022-08-16T04:23:29Z

Can rebase. I think using the actual USDC testnet ERC20 is important.

JoeGruffins · 2022-08-16T08:17:34Z

Need to figure out testnet or wait for it to work I guess before this pr is relevant again.

buck54321

Some observations from a cursory review. Looking good though.

client/asset/eth/eth.go

dex/networks/eth/tokens.go

buck54321 · 2022-10-19T00:37:27Z

dex/networks/eth/tokens.go

+				Address:       common.Address{},
+				SwapContracts: map[uint32]*SwapContract{},


Any reason not to populate this now?

We don't have a contract out yet do we? I guess the gasses would be the same?

buck54321 · 2022-10-19T00:41:42Z

dex/networks/eth/tokens.go

+				Address:       common.Address{},
+				SwapContracts: map[uint32]*SwapContract{},


Just a thought. No need for followup here. But @chappjc has seemingly found the actual USDC contracts. We could launch them with the simnet harness.

BTW, @chappjc's gist was the first google result for the search "usdc sol contract github".

JoeGruffins · 2022-10-27T09:12:37Z

Seems to be working fine. A few things not perfect yet:

The simnet harness tests often fail on TestTokenGasEstimates with:

  First swap used 170853 gas 
    1 additional swaps averaged 112586 gas each
    [170853 283439] 
  First redeem used 83874 gas 
    1 additional redeems averaged 31644 gas each
    [83874 115518] 
  Average of 2 refunds: 64337 
    [64337 64337] 
  Average of 2 approvals: 42802 
    [42802 42802] 
  Average of 2 transfers: 38800 
    [38800 38800] 
    nodeclient_harness_test.go:2458: getGasEstimates error: initiate error for 3 swaps: replacement transaction underpriced
--- FAIL: TestTokenGasEstimatesParticipant (252.42s)

I think I looked into this a few weeks ago and it was due to the nonce being reused or something. Will look again.

A few UI issues.

Rate rounding:

I don't think this is related to this issue. Two things happened that were unexpected. The server could not find a swap while the clients (infura) could. Which is concerning. But then after the taker here redeemed it sticks in an invalid coin. We don't know the tx that redeemed the contract without the server relaying that info to us from maker, but this should display something more informative I guess.

I made a comment about the same thing here #1866 (review)

JoeGruffins · 2022-10-27T09:19:05Z

server/market/orderrouter.go

-			if lo, ok := ord.(*order.LimitOrder); ok {
-				redeems = int(calc.QuoteToBase(lo.Rate, trade.Quantity) / tunnel.LotSize())
-			} else {
-				redeems = int(calc.QuoteToBase(safeMidGap(tunnel), trade.Quantity) / tunnel.LotSize())
-			}
+			redeems = int(trade.Quantity / tunnel.LotSize())


I think this was incorrect, please check me.

JoeGruffins · 2022-10-28T06:13:04Z

If going back to a client that doesn't have the new usdc id added the logs will show:

2022-10-28 06:09:16.001 [ERR] CORE: Route 'price_update' notification handler error (DEX 127.0.0.1:17273): error parsing market for base = 60001, quote = 42: base asset 60001 not found
2022-10-28 06:09:16.001 [ERR] CORE: Route 'price_update' notification handler error (DEX 127.0.0.1:17273): error parsing market for base = 60, quote = 60001: quote asset 60001 not found

So should probably handle that more gracefully since it is expected for new ids to exist that client may not know about yet.

JoeGruffins · 2022-10-28T06:23:41Z

I have now seen the replacement transaction error outside of tests so there is a bug somewhere. This was on master. Have never seen before and suspect it has to do with the provider changes:

2022-10-28 06:09:15.213 [ERR] CORE: 127.0.0.1:17273 tick error: 127.0.0.1:17273 tick: {redeemMatches order 66ede5fde8a9a5431bc1dfdeaf4cdae5c66150a383ad19132b755cf97b9b7433 - {error sending redeem transaction: Redeem: redeem error: replacement transaction underpriced}}

So it is trying to use a previous nonce but with the same gas fee? How do replacement transactions work now that you don't bid with a gas price?

chappjc · 2022-11-01T19:30:35Z

So it is trying to use a previous nonce but with the same gas fee?

That's unnerving. This is almost certainly an accidental replacement, right? sounds like a nonce tracking issue. Relying on multiple providers, or not allowing a provider to lag on next-nonce info?

How do replacement transactions work now that you don't bid with a gas price?

Good question. I would guess the tip.

JoeGruffins · 2022-11-03T02:15:42Z

Does the tip cap go to the stakers now?

JoeGruffins · 2022-11-04T07:46:19Z

Fixing the rate https://github.com/decred/dcrdex/compare/d22de7e94a7b97a27266dab4ece6d54bb8bb6868..8a38f65f33a857b5131f5b25aae45dc620e8b8b4

Not smart enough to know why, but moving multiplication first seems to be more precise https://go.dev/play/p/2mcaci8LGOF

The replacement transaction underpriced actually only seems to affect usdc, so maybe not because of recent changes. It happens a lot though so should be easy to find the reason.

chappjc · 2022-11-04T12:56:48Z

That's why we avoid floating point types like the plague in the backend. For ieee754 floats, you generally lose precision immediately for fractional values, while whole numbers can be represented exactly up to fairly large values (I think it's 2^53 for 64 bit floats). Naturally, Javascript offers neither a real integer type or an arbitrary precision integer type. Anyway, by multiplying the two integers first, you get a large integer exactly represented instead of a tiny decimal value number (with precision loss) that you then divide. I had to deal with this all the time with matlab and image processing and the lesson is don't assume floats are gonna be fine.

JoeGruffins · 2022-11-04T14:02:57Z

Added a cache that is working well in tests. Maybe a good solution to the nonce problem.

https://github.com/decred/dcrdex/compare/8a38f65f33a857b5131f5b25aae45dc620e8b8b4..0a14bc151202dd975e40da8c3d1f7543e88f82f7

JoeGruffins · 2022-11-04T14:04:44Z

Comment for last new method https://github.com/decred/dcrdex/compare/0a14bc151202dd975e40da8c3d1f7543e88f82f7..f002df7c908c4acd6615798c9e59d609c6e08913

buck54321 · 2022-11-04T15:24:52Z

Added a cache that is working well in tests. Maybe a good solution to the nonce problem.

https://github.com/decred/dcrdex/compare/8a38f65f33a857b5131f5b25aae45dc620e8b8b4..0a14bc151202dd975e40da8c3d1f7543e88f82f7

Did you try adjusting the nonceProviderStickiness?

JoeGruffins · 2022-11-30T06:42:59Z

Fix tests probably https://github.com/decred/dcrdex/compare/e491ed0cece1c150f621300f1af94a68aea96bc3..e9479b062e9a59022ffa9ba2cb339c91b4970c84

JoeGruffins · 2022-11-30T10:32:11Z

Ok, now they are fixed for sure https://github.com/decred/dcrdex/compare/e9479b062e9a59022ffa9ba2cb339c91b4970c84..b20ce45607fe929b82d3127ed59e153f70dcb566

chappjc · 2022-11-30T14:05:24Z

client/asset/eth/eth.go

+	err := f(contractor)
+	// If a transaction fails with a provider, trust the next nonce.
+	if err != nil {
+		if c, is := contractor.(*contractorV0); is {
+			if mRPC, is := c.cb.(*multiRPCClient); is {
+				mRPC.voidUnusedNonce()
+			}
+		}
+	}
+	return err


It certainly would be convenient to have the nonce returning done in a more central place like this, but withContractor is not just for contract interactions that involve a transaction. We have read-only contract API requests that involve no transaction and thus no preceding new-nonce request.

I think this needs to be done in the same function that did the nonce reservation itself, i.e. initiate, redeem, etc.

func (w *assetWallet) initiate(ctx context.Context, assetID uint32, contracts []*asset.Contract, maxFeeRate, gasLimit uint64, contractVer uint32) (tx *types.Transaction, err error) { var val uint64 if assetID == BipID { for _, c := range contracts { val += c.Value } } w.nonceSendMtx.Lock() defer w.nonceSendMtx.Unlock() // 1. get nonce txOpts, _ := w.node.txOpts(ctx, val, gasLimit, dexeth.GweiToWei(maxFeeRate)) // 2. attempt transaction with the nonce return tx, w.withContractor(contractVer, func(c contractor) error { tx, err = c.initiate(txOpts, contracts) if err != nil { // 3. return the unused nonce c.voidUnusedNonce() } return err }) }

func (c *contractorV0) voidUnusedNonce() { if mRPC, is := c.cb.(*multiRPCClient); is { mRPC.voidUnusedNonce() } }

Even that is a touch fishy though because it requires implementing voidUnusedNonce, but maybe alright.

Other ways to do this and be sure we're only targeting failed transactions?

There could be a txWithContractor function that is the same as withContractor but also voids the nonce. Then use that function for initiate, redeem, etc.

Put the void in init, redeem, refund, approve, and the sends https://github.com/decred/dcrdex/compare/b20ce45607fe929b82d3127ed59e153f70dcb566..f683573222317c8399e82ccff3439ab5e161f2c4

chappjc

Thanks for doing this nonce work. It's critical to get right.

A couple comments pertaining to the last diff.

client/asset/eth/eth.go

JoeGruffins · 2022-12-05T11:25:43Z

Allow nonce to be overridden for redeems https://github.com/decred/dcrdex/compare/d5ea00d49ef4a672c0edfac553d1666208ab4594..f011f1e3bc587a4e2207795c492a9b8dd4d1a2c2

client/asset/eth/eth.go

buck54321 · 2022-12-05T12:21:08Z

client/asset/eth/multirpc.go

@@ -502,6 +508,44 @@ func (m *multiRPCClient) connect(ctx context.Context) (err error) {
 	return nil
 }

+// unusedNonce returns true and saves the nonce for the next call when a nonce
+// has not been received recently.
+func (m *multiRPCClient) unusedNonce(nonce uint64) bool {


Would prefer registerNonce(nonce uint64) error semantics, but I'm not gonna fight you for it.

The registerNonce name certainly fits better with the method's functionality. Less fond of error returns when a flag serves the same purpose.

unusedNonce -> registerNonce

I don't feel an error is great because none of the outcomes are an error imo, unless the provider continues to give us a nonce we are sure we used. From testnet testing, we expect the same nonce to come back once sometimes from remote providers.

buck54321 · 2022-12-05T12:24:48Z

client/asset/eth/multirpc.go

+	checkDelay := time.Second * 5
+	for i := 0; i < checks; i++ {


OK for now, but we should look to move past our reliance on external sources permanently. We already are tracking recent txs with the monitoredTxs work. I wonder if we could spin that into double-duty for nonce generation too.

Continuation of the conversation at #1733 (comment)

Less reliance is better, but I think we'll always need some way to see what the chain thinks is the next nonce. Consider these cases: restore from seed, starting up after a while and the user has been messing in an external wallet with the same keys, "kvdb" failure, or just internal dex accounting bugs that could be catastrophic and have cascading effects if we don't at least occasionally "check in" with the chain. I think these are things that @JoeGruffins was alluding to in his response in the previous thread.

I don't think we've got the perfect solution yet either, but there's gotta be some way to have the chain (via rpc provider) inform us, but be more defensive against the possibility of being mislead by a trusted third party.

Oh, for sure. RPC wallet will always need to "seed" its nonce.

Leaving as is for now...

client/asset/eth/nodeclient_harness_test.go

buck54321 · 2022-12-05T12:41:53Z

client/asset/eth/nodeclient_harness_test.go

-			if diff.CmpAbs(dexeth.GweiToWei(1)) >= 0 { // Ugh. Need to get to != 0 again.
-				t.Fatalf("%s: unexpected parent chain balance change: want %d got %d, diff = %.9f",
-					test.name, dexeth.WeiToGwei(wantParentBal), dexeth.WeiToGwei(parentBal), float64(diff.Int64())/dexeth.GweiFactor)
+			if len(diff.Bits()) != 0 {


Why is what 😅

I think len(diff.Bits()) != 0 checks for a diff of 0, which is what we wanted, expected to be what we got. So no difference.

https://go.dev/play/p/vVeoUzZEvnz

Oh, the docs do say to avoid using it https://pkg.go.dev/math/big#Int.Bits so will change I guess.

Changed to diff.Cmp(big.NewInt(0)), if that was the problem

buck54321 · 2022-12-05T12:57:51Z

client/core/exchangeratefetcher.go

-		if sa.Wallet == nil {
+		// TODO: asset.Info will be nil for tokens. Make this work for
+		// tokens.
+		if sa.Wallet == nil || sa.Info == nil {


The only thing being use is the sa.Info.Name, which is now duplicated on the SupportedAsset, so you can use sa.Name instead. Just need to verify that coinpapSlug will work correctly.

Ok, did a slight hack to make the ids correct. Also the send screen will not show the fiat balance yet. Maybe can fix in another pr.

client/webserver/site/src/js/markets.ts

buck54321 · 2022-12-05T13:16:41Z

server/market/balancer.go

@@ -79,7 +79,7 @@ func NewDEXBalancer(tunnels map[string]PendingAccounter, assets map[uint32]*asse
 			}
 			bb.feeFamily[parentID] = parent.assetInfo
 			for tokenID := range asset.Tokens(parentID) {
-				if tokenID == assetID { // Don't double count
+				if tokenID == assetID || assets[tokenID] == nil { // Don't double count


Can you comment on the need for this?

I should have commented then because it's difficult to remember now. I think because we can have tokens specific to networks. So, usdc will not exist on simnet, but will be in the childrens map this is looking through. Let me confirm that.

Yes, that's it. Added a comment unless we should do more.

JoeGruffins · 2022-12-07T08:42:11Z

Hmm, panic after rebasing and starting client:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x80 pc=0x12b982d]

goroutine 130 [running]:
decred.org/dcrdex/client/core.(*Core).refundExpiredBonds(0xc000500800, {0x2151c78, 0xc000476100})
        /home/joe/git/dcrdex/client/core/bond.go:62 +0x16d
decred.org/dcrdex/client/core.(*Core).watchExpiredBonds(0x0?, {0x2151c78, 0xc000476100})
        /home/joe/git/dcrdex/client/core/bond.go:42 +0xa8
decred.org/dcrdex/client/core.(*Core).Run.func3()
        /home/joe/git/dcrdex/client/core/core.go:1544 +0x66
created by decred.org/dcrdex/client/core.(*Core).Run
        /home/joe/git/dcrdex/client/core/core.go:1542 +0x5ca

Maybe no dc yet?

2022-12-07 08:30:07.958 [ERR] CORE[wss://127.0.0.1:17273/ws]: Initial connection failed, starting reconnect loop: dial tcp 127.0.0.1:17273: connect: connection refused
2022-12-07 08:30:07.958 [ERR] CORE: Trouble establishing connection to 127.0.0.1:17273 (will retry). Error: dial tcp 127.0.0.1:17273: connect: connection refused
2022-12-07 08:30:08.622 [DBG] CORE: notify: |POKE| (conn) Server connected - dex-test.ssgen.io:7232 is connected
2022-12-07 08:30:08.789 [INF] CORE: Server dex-test.ssgen.io:7232 supports API version 0.
2022-12-07 08:30:08.789 [DBG] CORE: Server dex-test.ssgen.io:7232 broadcast timeout 22m0s. Tick interval 2m45s
2022-12-07 08:30:08.789 [INF] CORE: Connected to DEX server at dex-test.ssgen.io:7232 and listening for messages.
2022-12-07 08:30:08.789 [INF] CORE: Connected to 1 of 2 DEX servers
2022-12-07 08:30:08.789 [INF] CORE: Loaded 0 active orders.
2022-12-07 08:30:08.790 [INF] CORE: Loaded 5 active match orders
2022-12-07 08:30:08.792 [WRN] CORE: 

	 ****  IMPORTANT: You have 5 active orders on 127.0.0.1:17273. LOGIN immediately!  **** 

2022-12-07 08:30:08.792 [INF] CORE: Loaded 0 active orders.
2022-12-07 08:30:08.792 [INF] CORE: Loaded 0 active match orders
2022-12-07 08:30:08.792 [DBG] CORE: starting fiat rate fetching
2022-12-07 08:30:08.793 [DBG] WEB: Using embedded site resources.
2022-12-07 08:30:08.793 [INF] WEB: Using language en-US
2022-12-07 08:30:08.793 [INF] WEB: Using embedded HTML templates
2022-12-07 08:30:08.793 [INF] RPC: RPC server listening on 127.0.0.2:5757
2022-12-07 08:30:08.809 [INF] WEB: Web server listening on 127.0.0.2:5758

	****  OPEN IN YOUR BROWSER TO LOGIN AND TRADE  --->  http://127.0.0.2:5758  ****

2022-12-07 08:30:09.965 [ERR] CORE: unexpected response, got status code 404
2022-12-07 08:30:11.431 [ERR] CORE: unexpected response, got status code 404
2022-12-07 08:30:12.959 [INF] CORE[wss://127.0.0.1:17273/ws]: Attempting to reconnect to wss://127.0.0.1:17273/ws...
2022-12-07 08:30:12.960 [ERR] CORE[wss://127.0.0.1:17273/ws]: Reconnect failed. Scheduling reconnect to wss://127.0.0.1:17273/ws in 5.0 seconds.
2022-12-07 08:30:17.960 [INF] CORE[wss://127.0.0.1:17273/ws]: Attempting to reconnect to wss://127.0.0.1:17273/ws...
2022-12-07 08:30:17.961 [ERR] CORE[wss://127.0.0.1:17273/ws]: Reconnect failed. Scheduling reconnect to wss://127.0.0.1:17273/ws in 10.0 seconds.
2022-12-07 08:30:27.961 [INF] CORE[wss://127.0.0.1:17273/ws]: Attempting to reconnect to wss://127.0.0.1:17273/ws...
2022-12-07 08:30:27.962 [ERR] CORE[wss://127.0.0.1:17273/ws]: Reconnect failed. Scheduling reconnect to wss://127.0.0.1:17273/ws in 15.0 seconds.

Then panic.

Made #1989

JoeGruffins · 2022-12-07T13:52:12Z

@buck54321 review changes https://github.com/decred/dcrdex/compare/92a990056a780df7fffaaceb08d608f2b9019ffa..7c5656293a6daf2442847ea58fe64992e48ede61

client/asset/eth/eth.go

client/cmd/dexc-desktop/build/dexc_0.6.0-pre-0_amd64/DEBIAN/control

chappjc · 2022-12-13T16:41:01Z

client/asset/eth/nodeclient_harness_test.go

@@ -135,6 +135,8 @@ var (
 	// funds will be printed.
 	testnetWalletSeed            string
 	testnetParticipantWalletSeed string
+	usdcID, _                    = dex.BipSymbolID("usdc.eth")


EDIT: Github review is hiding the fact that this comment is part of a thread here: #1733 (comment)

A cli tool to run GetGasEstimates sounds smart to me (at some point). I'm also not fond of functions like that in the product code that are not intended to be used in the app.

However, we no longer do operator-set gasses (or transaction sizes for utxo assets), only fee rates. Clients only use their own baked-in trusted values. So if we want it back so that an operator can "adjust the gases up to a factor of 2, in case some unforeseen subtlety of an ERC20 contract", we'll have to modify the asset.Wallet interface again.
But I think we accepted, that a server changing a client's understanding of transaction "weight" (not just fee rate) is not a desirable approach, especially in light of mesh.

IMO we should pad the compiled-in gasses more generously. Consider: If you use metamask to interact with these contracts manually, it sets a surprisingly high gas limit for the transaction. See this comment regarding the approve method: #1733 (comment) I don't know how it gets the gas limit number (some evm simulation? eth_estimateGas at the provider?), but I think it's an indication that we should pad these numbers generously. In that limited test, it sets the gas limit to 150% of what the executed transaction ends up actually consuming.

client/asset/eth/nodeclient_harness_test.go

JoeGruffins · 2022-12-14T03:07:34Z

just rebased and removed unintended dexc-desktop folder

JoeGruffins · 2022-12-14T05:01:35Z

Addressing latest @chappjc comments https://github.com/decred/dcrdex/compare/2c396dd6945226914c019edf3a9a4bc8861685a6..8f4cd2aec322faf73866986eda7edcab3d29f216

chappjc

Working well!

dex-test updated with DCR-USDC.ETH market.

Tested using Ankr (https://www.ankr.com/rpc/eth?tab=get-started)

Goerli testnet

Here we have to fix the pre-swap fee projections when buying the token (as quote asset):

Approval automatically submitted. However, it used a gas limit of 400,000 instead of 65,000:

https://goerli.etherscan.io/tx/0x48405dbc89186d126b34f48d7b32063630a2733bca558dbe28f25aca7fac4aef

The gas limit on the initiate is extremely tight. We need more like 75% there:

https://goerli.etherscan.io/tx/0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1

Gas limit on the redeem is also very tight:

https://goerli.etherscan.io/tx/0x736e6a3ff53534046f05e9ed1bf16dc606efd69e3482caf54c94f13dadc336b2

2022-12-15 00:25:13.572 [DBG] CORE[eth][USDC.ETH]: Skipping live swap gas because contract is not approved for transferFrom
2022-12-15 00:25:14.866 [TRC] CORE[eth][ETH][RPC]: using cached header from "rpc.ankr.com"
2022-12-15 00:25:16.077 [TRC] CORE[eth][ETH][RPC]: Sending signed tx via "rpc.ankr.com"
2022-12-15 00:25:16.376 [INF] CORE[eth][USDC.ETH]: Approval sent for usdc.eth at token address 0x07865c6E87B9F70255377e024ace6630C1Eaa37F, nonce = 0

...

2022-12-15 00:35:07.909 [INF] CORE: Starting negotiation for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 with swap fee rate = 14, quantity = 200000000
2022-12-15 00:35:07.909 [DBG] CORE: Trade order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 matched with 1 orders: +200000000 filled, total fill 200000000 / 200000000 (100.0%)
2022-12-15 00:35:07.909 [DBG] CORE: notify: |POKE| (order) Matches made - Sell order on dcr-usdc.eth 100.0% filled (b23a2351) - Order: b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111
2022-12-15 00:35:07.910 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:07.911 [INF] CORE: Starting negotiation for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac with swap fee rate = 200, quantity = 200000000
2022-12-15 00:35:07.911 [DBG] CORE: Trade order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac matched with 1 orders: +200000000 filled, total fill 200000000 / 200000000 (100.0%)
2022-12-15 00:35:07.911 [DBG] CORE: notify: |POKE| (order) Matches made - Buy order on dcr-usdc.eth 100.0% filled (5514e2b0) - Order: 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac
2022-12-15 00:35:07.912 [DBG] CORE: Swappable match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac (Maker)
2022-12-15 00:35:07.912 [DBG] CORE: Using stored change coin address: 0x47e177f774e0Db1Cc68a7448135D3a10014E251f, amount:42580000, fees:35000000 (usdc.eth) for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac matches

...

2022-12-15 00:35:08.474 [DBG] CORE[eth][ETH]: tip change: 8136521 (0x1a9e1379ee77effffd762c21c6a37798cd2123f908e30744edc071bc2efe5572) => 8136522 (0x34b8db64f7370eb07b91ead2f48f2af83354ae20ae733fbbcb3b71e45998fa5e)
2022-12-15 00:35:08.474 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:35:08.474 [TRC] CORE: Processing tip change for eth
2022-12-15 00:35:08.828 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:35:08.845 [TRC] CORE[eth][ETH][RPC]: using cached header from "rpc.ankr.com"
2022-12-15 00:35:08.845 [DBG] CORE: Slow tick: trade b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 processed in 935.211907ms, blocked for 173ns
2022-12-15 00:35:10.068 [TRC] CORE[eth][ETH][RPC]: Sending signed tx via "rpc.ankr.com"
2022-12-15 00:35:11.114 [INF] CORE: Broadcasted transaction with 1 swap contracts for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac. Assigned fee rate = 200. Receipts (usdc.eth): [{ tx hash: 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1, contract address: 0x9E493d3766989e701797b9371682B7b94fD8Af9c, secret hash: 3aff97cefebb5572a4ed200c1e5fb0a3c9e0a0cf3f917a7b59256e0ececc4682 }].
2022-12-15 00:35:11.115 [INF] CORE: Contract coin 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1 (usdc.eth), value = 42580000, refundable at 2022-12-15 14:35:06 -0600 CST (receipt = { tx hash: 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1, contract address: 0x9E493d3766989e701797b9371682B7b94fD8Af9c, secret hash: 3aff97cefebb5572a4ed200c1e5fb0a3c9e0a0cf3f917a7b59256e0ececc4682 }), match = 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:35:11.115 [TRC] CORE: Contract coin 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1 secret = bbfda2973ec67850f03ac353016a522e19b9856d2c9dbab0424c6676bc98c830
2022-12-15 00:35:11.116 [INF] CORE: Notifying DEX dextesttaggpdj27s26wklczemovhqdzyvgokyumey33uemlw4imawqd.onion:7232 of our usdc.eth swap contract 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1 for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:35:11.116 [DBG] CORE: notify: |POKE| (order) Swaps initiated - Sent swaps worth 42.580000 USDC on order 5514e2b0 - Order: 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac
2022-12-15 00:35:11.116 [DBG] CORE: Slow tick: trade 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac processed in 3.204066028s, blocked for 183ns
2022-12-15 00:35:11.611 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:35:11.611 [INF] CORE: runJob(match) completed in 3.703908825s

...

2022-12-15 00:35:12.848 [DBG] CORE: Slow tick: trade 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac processed in 4.374342168s, blocked for 2.64177359s
2022-12-15 00:35:12.849 [INF] CORE: runJob(match_proof) completed in 440.147653ms
2022-12-15 00:35:12.942 [DBG] CORE: Received valid ack for 'init' request for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:35:12.942 [TRC] CORE[eth][ETH][RPC]: Sending signed tx via "rpc.ankr.com"
2022-12-15 00:35:12.944 [INF] CORE: Audited contract (usdc.eth: 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1) paying to 0x47e177f774e0Db1Cc68a7448135D3a10014E251f for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111, match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3, with tx data = true. Script: 000000003aff97cefebb5572a4ed200c1e5fb0a3c9e0a0cf3f917a7b59256e0ececc4682
2022-12-15 00:35:13.180 [TRC] CORE: notify: |DATA| (balance) balance updated

...

2022-12-15 00:35:18.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:18.762 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:18.818 [DBG] CORE[eth][ETH]: tip change: 8136522 (0x34b8db64f7370eb07b91ead2f48f2af83354ae20ae733fbbcb3b71e45998fa5e) => 8136523 (0xf9faf97445fe93bd015bcf309382d2cf51bbf8364ccc22e35a0cd71a2e35baa8)
2022-12-15 00:35:18.818 [TRC] CORE: Processing tip change for eth
2022-12-15 00:35:18.818 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:35:19.255 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:35:20.824 [DBG] CORE: Slow tick: trade 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac processed in 2.062211064s, blocked for 407ns
2022-12-15 00:35:20.824 [WRN] CORE: checkTrades completed in 2.487452626s (slow)
2022-12-15 00:35:22.548 [DBG] CORE: Slow tick: trade 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac processed in 3.72949721s, blocked for 2.005655373s

...

2022-12-15 00:35:22.987 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:35:29.475 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:40.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:51.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:35:51.937 [DBG] CORE[eth][ETH]: tip change: 8136523 (0xf9faf97445fe93bd015bcf309382d2cf51bbf8364ccc22e35a0cd71a2e35baa8) => 8136524 (0xf1cffe87cf35444ce6631fe60d06f8e1918756c4924f0bf64c2f57af4cbb1f29)
2022-12-15 00:35:51.937 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:35:51.937 [TRC] CORE: Processing tip change for eth
2022-12-15 00:35:52.410 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:35:52.735 [INF] CORE: Contract for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 with swap coin 0x21a47c304d514771c34dd671cda487fe321b22a81677918fe8a7f5ddd35116d1 (USDC.ETH) expires at 2022-12-15 14:35:06 -0600 CST (19h59m13s).
2022-12-15 00:35:52.753 [INF] CORE: Match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 not yet swappable: current confs = 1, required confs = 4

...

2022-12-15 00:36:35.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:36:35.907 [DBG] CORE[eth][ETH]: tip change: 8136526 (0x656d4a776b856fe0296149e7346c3984e978b2bb62e61009f3d37603a5ac7eca) => 8136527 (0x734573787a5f65497a4a6cdfd46459bdbe230be99874f3abc9f5755554ea3ca2)
2022-12-15 00:36:35.907 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:36:35.907 [TRC] CORE: Processing tip change for eth
2022-12-15 00:36:36.486 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:36.791 [DBG] CORE: Slow tick: trade 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac processed in 883.941621ms, blocked for 327ns
2022-12-15 00:36:36.807 [DBG] CORE: Swappable match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 (Taker)
2022-12-15 00:36:36.812 [DBG] CORE[dcr]: Change output size = 36, addr = TsnCApNFdyfnNVsfbgxJfdvQbS1EMfwpTvc
2022-12-15 00:36:36.813 [DBG] CORE[dcr]: 2 signature cycles to converge on fees for tx e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb: min rate = 14, actual fee rate = 14 (3500 for 250 bytes), change = true
2022-12-15 00:36:36.816 [DBG] CORE[dcr]: returning coins [42a1262ceb68abf46f3d1c74c23593c06792b63cf636b744f8ac72444b08d6fa:1]
2022-12-15 00:36:36.816 [INF] CORE: Broadcasted transaction with 1 swap contracts for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111. Assigned fee rate = 14. Receipts (dcr): [e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0].
2022-12-15 00:36:36.816 [INF] CORE: The following are contract identifiers mapped to raw refund transactions that are only valid after the swap contract expires. These are fallback transactions that can be used to return funds to your wallet in the case dexc no longer functions. They should NOT be used if dexc is operable. dexc will refund failed contracts automatically.
Refund Txs: {"e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0": 0100000001db7bdaef64eb802335dc91a0588612379ec7a493aa76ecb64df05c2ddc0914e70000000000feffffff01aab0eb0b0000000000001976a914087a5c5aec443b52ba2efffadc583587dcf6183288ac3adc9a63000000000100c2eb0b0000000000000000ffffffffce473044022045e8cfa8063d9ffb957aa130a474ca2504ab2757f1206e2de7cf09db7a8be28d0220799d67ae3c65af5571ada4aa21ed7b2f7d1e96f650549d4de104e40db679c7b101210259ba1e8832c4d065b81acc8fbd48bae05af8720e37ef2896dd7e0d2ab04ac651004c616382012088c0203aff97cefebb5572a4ed200c1e5fb0a3c9e0a0cf3f917a7b59256e0ececc46828876a914727704bd67afcfe7534e5b40525fc13043555dec67043adc9a63b17576a914087a5c5aec443b52ba2efffadc583587dcf618326888ac}
2022-12-15 00:36:36.817 [DBG] CORE: Saving change coin e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:1 (dcr) to DB for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111
2022-12-15 00:36:36.817 [INF] CORE: Contract coin e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0 (dcr), value = 200000000, refundable at 2022-12-15 08:35:06 +0000 UTC (receipt = e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0), match = 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:36:36.818 [INF] CORE: Notifying DEX dextesttaggpdj27s26wklczemovhqdzyvgokyumey33uemlw4imawqd.onion:7232 of our dcr swap contract e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0 for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:36:36.818 [DBG] CORE: notify: |POKE| (order) Swaps initiated - Sent swaps worth 2.00000000 DCR on order b23a2351 - Order: b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111
2022-12-15 00:36:36.818 [DBG] CORE: Slow tick: trade b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 processed in 911.239691ms, blocked for 296ns
2022-12-15 00:36:36.841 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:37.240 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:37.427 [TRC] CORE[eth][ETH][RPC]: using cached header from "rpc.ankr.com"
2022-12-15 00:36:40.672 [DBG] CORE: Received valid ack for 'init' request for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:36:40.673 [INF] CORE: Audited contract (dcr: e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0) paying to TsbTN5ynwpZjAWfAXeWLEZ7Xgn8hHtpX5qP for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac, match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3, with tx data = true. Script: 6382012088c0203aff97cefebb5572a4ed200c1e5fb0a3c9e0a0cf3f917a7b59256e0ececc46828876a914727704bd67afcfe7534e5b40525fc13043555dec67043adc9a63b17576a914087a5c5aec443b52ba2efffadc583587dcf618326888ac
2022-12-15 00:36:46.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:36:46.922 [DBG] CORE[eth][ETH]: tip change: 8136527 (0x734573787a5f65497a4a6cdfd46459bdbe230be99874f3abc9f5755554ea3ca2) => 8136528 (0xbba3ed68cbb2b7dbaacc289c15ef95f6beaae1aae4f20ad8d989442a4c0b2291)
2022-12-15 00:36:46.922 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:36:46.922 [TRC] CORE: Processing tip change for eth
2022-12-15 00:36:46.924 [INF] CORE: Contract for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 with swap coin e71409dc2d5cf04db6ec76aa93a4c79e37128658a091dc352380eb64efda7bdb:0 (DCR) expires at 2022-12-15 08:35:06 +0000 UTC (7h58m19s).
2022-12-15 00:36:46.924 [DBG] CORE: Redeemable match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac (Maker)
2022-12-15 00:36:46.925 [TRC] CORE[dcr]: Obtained estimate for 1-conf fee rate, 10
2022-12-15 00:36:46.931 [INF] CORE: Broadcasted redeem transaction spending 1 contracts for order 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac, paying to bd2c17ab74ea2bd47ba554210188124517f7d138fc4a6a611ede376681afd09b:0 (dcr)
2022-12-15 00:36:46.932 [INF] CORE: Match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 complete: buy 200000000 dcr
2022-12-15 00:36:46.933 [INF] CORE: Notifying DEX dextesttaggpdj27s26wklczemovhqdzyvgokyumey33uemlw4imawqd.onion:7232 of our dcr swap redemption bd2c17ab74ea2bd47ba554210188124517f7d138fc4a6a611ede376681afd09b:0 for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:36:46.933 [DBG] CORE: notify: |POKE| (order) Match complete - Redeemed 2.00000000 DCR on order 5514e2b0 - Order: 5514e2b0a5cd1c0059a0dc3de03441985dacc27fc1a0746d35af9370a623dcac
2022-12-15 00:36:46.963 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:47.358 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:47.444 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:47.519 [DBG] CORE[dcr]: tip change: 1048109 (00000000107e6cc423ab69274d44b252c926783e6fe5c9df3281def684cb94cb) => 1048110 (0000000075fa1ace33b994f55fd5c5bd16f5e67bb712b94268ddaaa2d1dfdea4)
2022-12-15 00:36:47.519 [TRC] CORE: Processing tip change for dcr
2022-12-15 00:36:47.544 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:50.814 [DBG] CORE: Received valid ack for 'redeem' request for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3)
2022-12-15 00:36:50.814 [INF] CORE: Notified of maker's redemption (dcr: bd2c17ab74ea2bd47ba554210188124517f7d138fc4a6a611ede376681afd09b:0) and validated secret for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111...
2022-12-15 00:36:50.816 [DBG] CORE: Redeemable match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 (Taker)
2022-12-15 00:36:52.617 [TRC] CORE[eth][ETH][RPC]: using cached header from "rpc.ankr.com"
2022-12-15 00:36:53.047 [TRC] CORE[eth][ETH][RPC]: using cached header from "rpc.ankr.com"
2022-12-15 00:36:54.423 [TRC] CORE[eth][ETH][RPC]: Sending signed tx via "rpc.ankr.com"
2022-12-15 00:36:55.042 [INF] CORE: Broadcasted redeem transaction spending 1 contracts for order b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111, paying to 0x736e6a3ff53534046f05e9ed1bf16dc606efd69e3482caf54c94f13dadc336b2 (usdc.eth)
2022-12-15 00:36:55.043 [INF] CORE: Match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 complete: sell 200000000 dcr
2022-12-15 00:36:55.044 [INF] CORE: Notifying DEX dextesttaggpdj27s26wklczemovhqdzyvgokyumey33uemlw4imawqd.onion:7232 of our usdc.eth swap redemption 0x736e6a3ff53534046f05e9ed1bf16dc606efd69e3482caf54c94f13dadc336b2 for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3
2022-12-15 00:36:55.044 [DBG] CORE: notify: |POKE| (order) Match complete - Redeemed 42.580000 USDC on order b23a2351 - Order: b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111
2022-12-15 00:36:55.044 [DBG] CORE: Slow tick: trade b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 processed in 4.227939311s, blocked for 210ns
2022-12-15 00:36:55.044 [INF] CORE: runJob(match_proof) completed in 755.477414ms
2022-12-15 00:36:55.067 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:55.484 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:36:57.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:36:59.069 [TRC] CORE: Received a courtesy redemption request for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3 as maker
2022-12-15 00:36:59.070 [DBG] CORE: Received valid ack for 'redeem' request for match 24d55c264b1ae28b0b9af8132e6ddd151ec9e5b70e90116d700b2a2dd7e234c3)

...

2022-12-15 00:37:08.928 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:37:08.928 [TRC] CORE: Processing tip change for eth
2022-12-15 00:37:09.524 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:37:10.617 [DBG] CORE: Slow tick: trade b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 processed in 1.688640682s, blocked for 285ns

...

2022-12-15 00:39:09.474 [TRC] CORE[eth][ETH][RPC]: fetching fresh header from "rpc.ankr.com"
2022-12-15 00:39:09.918 [DBG] CORE[eth][ETH]: tip change: 8136537 (0x69d069b4a911f83e1a03a9a4701505146cfcfec4f898342494743eb7db34f658) => 8136538 (0xb7aa7677a3a8ea29f192ff0bd5f7c9c3fdafa3c375cfead03888c8949099a94d)
2022-12-15 00:39:09.918 [TRC] CORE: Processing tip change for usdc.eth
2022-12-15 00:39:09.918 [TRC] CORE: Processing tip change for eth
2022-12-15 00:39:10.378 [TRC] CORE: notify: |DATA| (balance) balance updated
2022-12-15 00:39:11.291 [INF] CORE: notify: |SUCCESS| (match) Redemption Confirmed - Your redemption for match 24d55c26 in order b23a2351 was confirmed
2022-12-15 00:39:11.291 [DBG] CORE: Slow tick: trade b23a23514b4ac05246537225e87924e51c27f3d8a96eddcc706d100ba816f111 processed in 1.372469443s, blocked for 275ns
2022-12-15 00:39:11.706 [TRC] CORE: notify: |DATA| (balance) balance updated

Ticks are slow. To be expected with a remote provider I suppose, but it backs up the tick loop and trades have to wait on eachother.

Did a second swap with maker/taker switched:

The /api/maxbuy and /api/preorder endpoints were extremely slow:

2022-12-15 00:33:43.159 [INF] CORE[eth][USDC.ETH]: MaxOrder reducing lots because of low fee reserves: 22 -> 2
2022/12/14 18:33:43 "POST http://127.0.0.2:5758/api/maxbuy HTTP/1.1" from 127.0.0.1:38366 - 200 198B in 2.490447686s
2022-12-15 00:33:46.367 [INF] CORE[eth][USDC.ETH]: MaxOrder reducing lots because of low fee reserves: 22 -> 2
2022/12/14 18:33:47 "POST http://127.0.0.2:5758/api/preorder HTTP/1.1" from 127.0.0.1:38366 - 200 723B in 3.39130873s

We'll have to look into that. It's going to be a problem. The UX is already poor with a long wait to submit an order.

JoeGruffins · 2022-12-15T02:53:10Z

Approval automatically submitted. However, it used a gas limit of 400,000 instead of 65,000

what

chappjc · 2022-12-15T02:57:29Z

Approval automatically submitted. However, it used a gas limit of 400,000 instead of 65,000

what

Indeed. https://goerli.etherscan.io/tx/0x48405dbc89186d126b34f48d7b32063630a2733bca558dbe28f25aca7fac4aef
No idea how that happened.

norwnd · 2022-12-19T12:14:10Z

Was reading the relevant code, noticed that answer could be because it is directly using this constant value: approveGas = 4e5 here, maybe just forgotten artefact ? cc @JoeGruffins

JoeGruffins force-pushed the addudsc branch from 9d7413e to fc5b42a Compare July 26, 2022 10:05

chappjc added this to the 0.6/1.0 milestone Aug 12, 2022

JoeGruffins force-pushed the addudsc branch 3 times, most recently from 4c4cda8 to a69d511 Compare September 22, 2022 08:25

JoeGruffins force-pushed the addudsc branch 2 times, most recently from c8f6e45 to 9fcd4b4 Compare October 4, 2022 08:27

chappjc added the ETH label Oct 12, 2022

buck54321 reviewed Oct 19, 2022

View reviewed changes

JoeGruffins force-pushed the addudsc branch 2 times, most recently from f9700e1 to dbd42f0 Compare October 27, 2022 09:03

JoeGruffins marked this pull request as ready for review October 27, 2022 09:04

JoeGruffins commented Oct 27, 2022

View reviewed changes

JoeGruffins force-pushed the addudsc branch from dbd42f0 to 8526b47 Compare November 1, 2022 08:44

JoeGruffins force-pushed the addudsc branch 2 times, most recently from d22de7e to 8a38f65 Compare November 4, 2022 07:43

JoeGruffins force-pushed the addudsc branch from 8a38f65 to 0a14bc1 Compare November 4, 2022 14:01

JoeGruffins force-pushed the addudsc branch from 0a14bc1 to f002df7 Compare November 4, 2022 14:04

JoeGruffins force-pushed the addudsc branch from e491ed0 to e9479b0 Compare November 30, 2022 06:41

JoeGruffins force-pushed the addudsc branch from e9479b0 to b20ce45 Compare November 30, 2022 10:31

chappjc reviewed Nov 30, 2022

View reviewed changes

JoeGruffins force-pushed the addudsc branch from b20ce45 to f683573 Compare December 1, 2022 04:23

chappjc self-requested a review December 2, 2022 16:39

chappjc reviewed Dec 2, 2022

View reviewed changes

client/asset/eth/eth.go Show resolved Hide resolved

client/asset/eth/eth.go Outdated Show resolved Hide resolved

JoeGruffins force-pushed the addudsc branch 2 times, most recently from d5ea00d to f011f1e Compare December 5, 2022 11:24

buck54321 reviewed Dec 5, 2022

View reviewed changes

JoeGruffins force-pushed the addudsc branch from f011f1e to 92a9900 Compare December 7, 2022 05:13

JoeGruffins force-pushed the addudsc branch from 92a9900 to 7c56562 Compare December 7, 2022 13:50

chappjc requested changes Dec 13, 2022

View reviewed changes

JoeGruffins force-pushed the addudsc branch from 7c56562 to 2c396dd Compare December 14, 2022 03:06

erc20: Add testnet usdc.

8f4cd2a

JoeGruffins force-pushed the addudsc branch from 2c396dd to 8f4cd2a Compare December 14, 2022 04:55

chappjc approved these changes Dec 15, 2022

View reviewed changes

chappjc merged commit 9d00904 into decred:master Dec 15, 2022

This was referenced Jan 11, 2023

enable eth and usdc.eth on mainnet #2013

Merged

erc20: token fee estimates on ui are wild #2041

Closed

chappjc mentioned this pull request Apr 8, 2023

ui: consistent rate formatting #2278

Merged

		Address: common.Address{},
		SwapContracts: map[uint32]*SwapContract{},

erc20: Add testnet usdc. #1733

erc20: Add testnet usdc. #1733

Conversation

JoeGruffins commented Jul 26, 2022 • edited Loading

chappjc commented Aug 16, 2022

JoeGruffins commented Aug 16, 2022

buck54321 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Oct 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Oct 27, 2022 • edited Loading

Choose a reason for hiding this comment

JoeGruffins commented Oct 28, 2022 • edited Loading

JoeGruffins commented Oct 28, 2022 • edited Loading

chappjc commented Nov 1, 2022

JoeGruffins commented Nov 3, 2022 • edited Loading

JoeGruffins commented Nov 4, 2022 • edited Loading

chappjc commented Nov 4, 2022

JoeGruffins commented Nov 4, 2022 • edited Loading

JoeGruffins commented Nov 4, 2022

buck54321 commented Nov 4, 2022

JoeGruffins commented Nov 30, 2022 • edited Loading

JoeGruffins commented Nov 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc left a comment

Choose a reason for hiding this comment

JoeGruffins commented Dec 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc Dec 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Dec 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Dec 7, 2022 • edited Loading

JoeGruffins commented Dec 7, 2022

chappjc Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

JoeGruffins commented Dec 14, 2022

JoeGruffins commented Dec 14, 2022

chappjc left a comment

Choose a reason for hiding this comment

JoeGruffins commented Dec 15, 2022

chappjc commented Dec 15, 2022

norwnd commented Dec 19, 2022 • edited Loading

JoeGruffins commented Jul 26, 2022 •

edited

Loading

JoeGruffins Oct 27, 2022 •

edited

Loading

JoeGruffins commented Oct 27, 2022 •

edited

Loading

JoeGruffins commented Oct 28, 2022 •

edited

Loading

JoeGruffins commented Oct 28, 2022 •

edited

Loading

JoeGruffins commented Nov 3, 2022 •

edited

Loading

JoeGruffins commented Nov 4, 2022 •

edited

Loading

JoeGruffins commented Nov 4, 2022 •

edited

Loading

JoeGruffins commented Nov 30, 2022 •

edited

Loading

chappjc Dec 5, 2022 •

edited

Loading

JoeGruffins Dec 7, 2022 •

edited

Loading

JoeGruffins commented Dec 7, 2022 •

edited

Loading

chappjc Dec 13, 2022 •

edited

Loading

norwnd commented Dec 19, 2022 •

edited

Loading