blockchain: Refactor main block index logic. #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2018
davecgh
force-pushed
the
blockchain_separate_blockindex
branch
from
5d42d19 to
426105c
Compare
|
Rebased to deal with the merge of #915 and also modified |
davecgh
force-pushed
the
blockchain_separate_blockindex
branch
4 times, most recently
from
11798eb to
d44733d
Compare
alexlyp
approved these changes
Jan 29, 2018
This refactors the block index logic into a separate struct and introduces an individual lock for it so it can be queried independent of the chain lock. It also modifies the `newBlockNode` function to accept nil for the ticket spend information parameter and updates all of the test code that doesn't require it to use nil.
davecgh
force-pushed
the
blockchain_separate_blockindex
branch
from
d44733d to
2296b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #989.
This refactors the block index logic into a separate struct and introduces an individual lock for it so it can be queried independent of the chain lock.
It also modifies the
newBlockNodefunction to accept nil for the ticket spend information parameter and updates all of the test code that doesn't require it to use nil.