docs: Add fullblocktests entry and minor consistency updates #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces package connmgr which contains connection management related functionality. The following is an overview of the features the package provides: - Maintain fixed number of outbound connections - Optional connect-only mode - Retry persistent connections with increasing back-off - Source peers from DNS seeds - Use Tor to resolve DNS - Dynamic ban scores - Test coverage In addition, btcd has been refactored to make use of the new package by extending the connection manager to work with the server to source and maintain peer connections. The following is a broad overview of the changes to integrate the package: - Simplify peer state by removing pending, retry peers - Refactor to remove retries which are now handled by connmgr - Use callback to add addresses sourced from the DNS seed Finally the following connection-related things have been improved as a part of this refactor: - Fixes 100% cpu usage when network is down (decred#129) - Fixes issues with max peers (decred#577) - Simplify outbound peer connections management
davecgh
requested changes
Dec 30, 2017
docs/README.md
Outdated
| @@ -209,6 +209,8 @@ information. | |||
| Provides a common base for creating and managing Decred network peers. | |||
| * [blockchain](https://github.com/decred/dcrd/tree/master/blockchain) - | |||
| Implements Decred block handling and chain selection rules | |||
| * [blockchain/fullblocktests](https://github.com/btcsuite/decred/tree/master/blockchain/fullblocktests) - | |||
| Provides a set of block tests for testing the consensus validation rules | |||
There was a problem hiding this comment.
The entries are not consistent in leading spaces which is what the intent of the commit being merged from upstream was. It needs to be applied to not only this line, but all the others as well.
In particular notice how the lines with the bullet points have leading spaces while the continuation lines are tabs. They all need to be spaces to be consistent.
dnldd
force-pushed
the
merge_fullblocktests_add_doc
branch
from
e9b44a3 to
1efdc1a
Compare
dnldd
force-pushed
the
merge_fullblocktests_add_doc
branch
from
1efdc1a to
bd8ff54
Compare
davecgh
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of the following upstream commit: