addrmgr: Test removal of corrupt peers file. #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Mar 5, 2018
addrmgr/addrmanager_test.go
Outdated
| @@ -498,3 +498,26 @@ func TestNetAddressKey(t *testing.T) { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| func TestCorruptPeersFile(t *testing.T) { | |||
| dir, err := ioutil.TempDir("", "testaddressbyip") | |||
There was a problem hiding this comment.
Shouldn't the prefix be changed here to be unique for the test?
There was a problem hiding this comment.
Good catch, changed accordingly!
Add unit test to ensure the removal of corrupt peers files. Also fix some typos.
markusrichter
force-pushed
the
addrmgr-test
branch
from
0eb3dd0 to
c49a9bd
Compare
davecgh
approved these changes
Mar 6, 2018
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Oct 21, 2018
fix NewImportAddressCmd rescan wrong parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test to ensure the removal of corrupt peers files.
Also fix some typos.
Increases test coverage from 78.4% to 79.5%.