chaingen: Prevent dup block names in NextBlock. #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Feb 24, 2018
davecgh
force-pushed
the
chaingen_no_dup_block_names
branch
2 times, most recently
from
d4afaa6 to
ac8ecbe
Compare
|
Rebased to latest master and fixed conflicts introduced by #1060. |
This modifies the chaingen test harness to error when a duplicate block name is provided to NextBlock to help prevent misuse. It also orrects a couple of comment typos.
davecgh
force-pushed
the
chaingen_no_dup_block_names
branch
from
ac8ecbe to
0aa73c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
chaingentest harness to error when a duplicate block name is provided toNextBlockto help prevent misuse.It also corrects a couple of comment typos.