blockchain: Refactor block idx entry serialization. #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_refactor_blockindex_entry_serialization
branch
from
b2607d1 to
3588610
Compare
This modifies the newly added block index serialization code to use a separate structure as opposed to working with block nodes directly. This approach is more desirable because it provides better separation and more robust code against changes to the block node structure itself and it avoids complications dealing with non-serialized fields such as parent and child pointers.
davecgh
force-pushed
the
blockchain_refactor_blockindex_entry_serialization
branch
from
3588610 to
b4d9d44
Compare
alexlyp
approved these changes
Feb 23, 2018
davecgh
deleted the
blockchain_refactor_blockindex_entry_serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the newly added block index serialization code to use a separate structure as opposed to working with block nodes directly.
This approach is more desirable because it provides better separation and more robust code against changes to the block node structure itself and it avoids complications dealing with non-serialized fields such as
parent and child pointers.