blockchain: Do not accept orphans/genesis block. #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_accept_no_orphans
branch
from
fe9edef to
f58aeb2
Compare
This modifies the code in maybeAcceptBlock to return an error if there is no previous entry in the block index for a given block indicating it is either an orphan or the genesis block. The function should never be called in either circumstance since the genesis block is valid by definition and orphans are handled prior to calling the function.
davecgh
force-pushed
the
blockchain_accept_no_orphans
branch
from
f58aeb2 to
cc6f0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the code in
maybeAcceptBlockto return an error if there is no previous entry in the block index for a given block indicating it is either an orphan or the genesis block.The function should never be called in either circumstance since the genesis block is valid by definition and orphans are handled prior to calling the function.