blockchain: Validate allowed revokes in blk contxt. #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the test for validating the votes in the block are eligible votes per the results of the ticket lottery into the checkBlockContext function where it more naturally belongs since it is only dependent on the block and its contextual position within the chain. While here, it also refactors the check into a separate function named checkAllowedVotes to improve readability.
This moves the test for validating the revocations in the block are actually eligible to be revoked per the results of the ticket lottery into the checkBlockContext function where it more naturally belongs since it is only dependent on the block and its contextual position within the chain. While here, it also refactors the check into a separate function named checkAllowedRevocations to improve readability. Also, since this was the final check in the CheckBlockStakeSanity function, that entire function has been removed along with its call site.
jrick
approved these changes
Feb 15, 2018
alexlyp
approved these changes
Feb 15, 2018
davecgh
deleted the
blockchain_validate_allowed_revocations_block_context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the test for validating the revocations in the block are actually eligible to be revoked per the results of the ticket lottery into the
checkBlockContextfunction where it more naturally belongs since it is only dependent on the block and its contextual position within the chain.While here, it also refactors the check into a separate function named
checkAllowedRevocationsto improve readability. Also, since this was the final check in theCheckBlockStakeSanityfunction, that entire function has been removed along with its call site.