stake: Static assert of vote commitment. #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
stake_static_vote_commitment_extraction
branch
from
85fba16 to
1640b16
Compare
jrick
approved these changes
Feb 2, 2018
alexlyp
approved these changes
Feb 2, 2018
This modifies the SSGenBlockVotedOn function to directly copy the hash the vote commits to into a statically sized array versus calling the hash function and thus can remove the potential runtime error. This is preferred because the code will fail to compile if the size of chainhash.HashSize is every changed which is desirable because it would mean the assumptions the code makes would be invalidated. It also updates all callers in the repository accordingly.
davecgh
force-pushed
the
stake_static_vote_commitment_extraction
branch
from
1640b16 to
d357113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
SSGenBlockVotedOnfunction to directly copy the hash the vote commits to into a statically sized array versus calling the hash function and thus can remove the potential runtime error.This is preferred because the code will fail to compile if the size of
chainhash.HashSizeis every changed which is desirable because it would mean the assumptions the code makes would be invalidated.It also updates all callers in the repository accordingly.