blockchain/mining: Full checks in CCB. #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 2, 2018
davecgh
force-pushed
the
blockchain_checkconnectblock_full
branch
2 times, most recently
from
ef8d92e to
cba0f6a
Compare
This modifies the exported CheckConnectBlock function to call the checkBlockSanity and checkBlockContext functions to ensure all validation rules are enforced from the mining code. Since both the mining code and tests typically work with unsolved blocks, this also introduces a new parameter on CheckConnectBlock to pass behavior flags which allows the caller to skip the proof of work check. It also modifies forceHeadReorganization to call checkBlockContext for the same reason. Finally, all tests and call sites are updated with the appropriate flags and various tests are updated for the changes accordingly.
davecgh
force-pushed
the
blockchain_checkconnectblock_full
branch
from
cba0f6a to
21e9a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1014.
This modifies the exported
CheckConnectBlockfunction to call thecheckBlockSanityandcheckBlockContextfunctions to ensure all validation rules are enforced from the mining code.Since both the mining code and tests typically work with unsolved blocks, this also introduces a new parameter on
CheckConnectBlockto pass behavior flags which allows the caller to skip the proof of work check.It also modifies
forceHeadReorganizationto callcheckBlockContextfor the same reason.Finally, all tests and call sites are updated with the appropriate flags and various tests are updated for the changes accordingly.