blockchain: Validate num votes in header sanity. #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 1, 2018
jrick
approved these changes
Feb 1, 2018
davecgh
force-pushed
the
blockchain_validate_numvotes_header_sanity
branch
3 times, most recently
from
b6a3511 to
918e7c0
Compare
This moves the test for validating the number of votes specified by the header is at least the required minimum into the checkBlockHeaderSanity function where it more naturally belongs since it is solely dependent on information the header. Also, remove the redundant check for the same condition from checkBlockSanity since it has now already been checked according to the value the header commits to and therefore validating the header commitment for the number of votes implies correctness.
davecgh
force-pushed
the
blockchain_validate_numvotes_header_sanity
branch
from
918e7c0 to
1273cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the test for validating the number of votes specified by the header is at least the required minimum into the
checkBlockHeaderSanityfunction where it more naturally belongs since it is solely dependent on information the header.Also, remove the redundant check for the same condition from
checkBlockSanitysince it has now already been checked according to the value the header commits to and therefore validating the header commitment for the number of votes implies correctness.