fix: OpenAPI name, version and x-methods #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #301 +/- ##
==========================================
- Coverage 65.53% 65.36% -0.17%
==========================================
Files 64 64
Lines 1555 1559 +4
Branches 242 245 +3
==========================================
Hits 1019 1019
- Misses 441 445 +4
Partials 95 95 |
mirceanis
approved these changes
Dec 15, 2020
| @@ -25,7 +25,7 @@ export class AgentRestClient implements IAgentPlugin { | |||
| } | |||
|
|
|||
| // @public (undocumented) | |||
| export const getOpenApiSchema: (agent: IAgent, basePath: string, exposedMethods: Array<string>) => OpenAPIV3.Document; | |||
| export const getOpenApiSchema: (agent: IAgent, basePath: string, exposedMethods: Array<string>, name?: string | undefined, version?: string | undefined) => OpenAPIV3.Document; | |||
There was a problem hiding this comment.
Just curious here, do you need to explicitly define the params as string | undefined if they already have a question mark?
There was a problem hiding this comment.
This generated by api-exctractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.