Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update 'packages/core-types/src/types/ICredentialIssuer.ts' #1359

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

hylim-tech-lover
Copy link
Contributor

@hylim-tech-lover hylim-tech-lover commented Mar 4, 2024

What issue is this PR fixing

closes #1356

What is being changed

packages/core-types/src/types/ICredentialIssuer.ts is updated with correct description for type definition

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

If applicable, add screen captures, error messages or stack traces to help explain your problem.

@nickreynolds nickreynolds merged commit 5c858be into decentralized-identity:next Mar 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Update doc comments to prevent misunderstanding
2 participants