Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "empty" field to date and datetime widgets. #833

Closed
wants to merge 1 commit into from
Closed

Add "empty" field to date and datetime widgets. #833

wants to merge 1 commit into from

Conversation

drlogout
Copy link
Contributor

@drlogout drlogout commented Nov 18, 2017

- Summary

This PR adds an "empty" field to the date and datetime widgets. E.g. a list widget called events has a start and an end date widget. If empty: true is added to the end date widget, the user can handle the end date optionally.

...
fields:
  - name: events
     label: Events
     widget: list
     fields:
       - {label: "Name", name: "name", widget: "string"}
       - {label: "Start date", name: "start_date", widget: "date"}
       - {label: "End date", name: "end_date", widget: "date", empty: true}

@erquhart
Copy link
Contributor

erquhart commented Nov 27, 2017

@drlogout sorry for the delay here - have you checked out @bruce-one's work in #645?

I would love your thoughts on that based on your use case. If you could try it out locally and provide a review it'd help get it merged.

@erquhart
Copy link
Contributor

Closing in favor of #842.

@erquhart erquhart closed this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants