feat: workflow unpublished entry #2914
Conversation
|
I'm not entirely sure about the color scheme for the button, I associate green with actions like publishing, not unpublishing. Maybe we should use a gray version. I prefer this one Over the default: The other colored buttons used are a bit harsh IMHO. Thoughts? |
|
If we are going gray for |
|
Why? It's already a different color button.. |
| @@ -63,6 +64,8 @@ const en = { | |||
| publishing: 'Publishing...', | |||
| publish: 'Publish', | |||
| published: 'Published', | |||
| unpublish: 'Unpublish entry', | |||
| unpublishing: 'Unpublishing', | |||
There was a problem hiding this comment.
Should be Unpublishing... similar to Publishing... right?
|
How about:
Or:
|
| @@ -63,6 +64,8 @@ const en = { | |||
| publishing: 'Publishing...', | |||
| publish: 'Publish', | |||
| published: 'Published', | |||
| unpublish: 'Unpublish entry', | |||
There was a problem hiding this comment.
Can we use just Unpublish like Publish and create new or Publish now?
|
@barthc looks good pending UI decisions. Also do you mind adding a scenario for unpublishing for the test backend in the Cypress tests? |
|
@erezrokah Digging that first one! |
Just thinking we should be consistent with one of these: |
|
Even better! |
|
@erezrokah honestly the dropdown |
|
That settles it then 😄 |
erezrokah
force-pushed
the
feat/workflow-unpublish-post
branch
from
be5ba4f to
72a0bb8
Compare
|
@tomrutgers, @barthc I rebased the branch, made the UI changes, added a cypress test and a fix to re-load the unpublished entry (was needed due to this recent change: https://github.com/netlify/netlify-cms/pull/2878/files#diff-7d0283827744acf7472c54d35c205500R305). |
|
@erezrokah was about to push changes for the dropdown and the cypress test 😀 |
|
Looking good! |
|
@barthc Sorry for that, I'm pushing for keeping the PR number low and we have some more changes coming around that area :) |
* feat: workflow unpublished entry * fix: post rebase fix - load unpublished entry after unpublish * feat: change unpublish button to dropdown * test(cypress): add unpublish entry cypress test
* feat: workflow unpublished entry * fix: post rebase fix - load unpublished entry after unpublish * feat: change unpublish button to dropdown * test(cypress): add unpublish entry cypress test
Summary
Closes #727
Currently swap the editorial toolbar section from:
to:
cc: @tomrutgers